From patchwork Thu Aug 17 22:35:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9907231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 36F986038C for ; Thu, 17 Aug 2017 22:36:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2962F28B49 for ; Thu, 17 Aug 2017 22:36:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1E3BD28BFB; Thu, 17 Aug 2017 22:36:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B75B728B49 for ; Thu, 17 Aug 2017 22:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbdHQWgP (ORCPT ); Thu, 17 Aug 2017 18:36:15 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33213 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbdHQWgO (ORCPT ); Thu, 17 Aug 2017 18:36:14 -0400 Received: by mail-wr0-f195.google.com with SMTP id n88so10664477wrb.0 for ; Thu, 17 Aug 2017 15:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0n5tAcP2qyD2Jw0MKxFM4AspFwTbFNRqbDG6scXs6t8=; b=O02xubeXA6pdyA7lHINZhgDlGNEFGyYzeAHj0IOmDXYvYCUoT+uNOT/WEP+OfLoTlX Y60+5DetYPK30N8tMki716tphDTvX2IhFSuHB9gAviIYPud9Gi/rpbWZdI2D1w3chK+M ZAnDMjtHtblCN7FuPvbm0mMO43Hl2FSGfRjKKsVuwJnU8ORNQdk22T7lkg12fAtl7aYs MVqMbHgs39x5g2+6nRuVLVKVArNOPiMOIHT8kEWeWLfMU9BgLmS3JLnXnw6KUohblhhP TfsMBUkGEOz59MpTA6B8lC2xmsdtN5FchvtQZp35ZYcMmGPFuesfaOzN2leUE4xzsKpr FIwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0n5tAcP2qyD2Jw0MKxFM4AspFwTbFNRqbDG6scXs6t8=; b=Gu48hWduzxL3yZ1dQwPwcpwVIIFTd9FrdzLdfK2O8dOUhZxnljTaPfs3sIijk7o8Wk F9N2aazEd8F305c984P/wKM0AdEjnwssR0Kx1CVkzSvPPu9JLyb8jiB8iKatNIeMV8LG xVgf1dPX/Vrld2iYXVU2a8x4SnXGSAgs6Jvz/GAyTrp4evaIsNclaWWeIIUIlZC5aKXc S/JC9eiCtjchnkMYQnEBFxpVi3GbddkO7TZodRt+Nzv3OoZzylqiCGglqpvVkVTeNV0v SX3myyc2NSw+k8YpKZw9fCvH2cPNGrTjlzWjPaL3TUIpoCWfc1+qCXg/goyTfV0nn2N/ mYaA== X-Gm-Message-State: AHYfb5j86NdNB6R4yGCcmoV+ZDSM+AT05yGMMLOiVSNOx4phyndLvdzc ZnkafQ6P6JzwKJ/QeeI= X-Received: by 10.80.218.195 with SMTP id s3mr2971778edj.216.1503009373622; Thu, 17 Aug 2017 15:36:13 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:bd00:c690:eda9:7a94]) by smtp.gmail.com with ESMTPSA id g54sm2882230eda.19.2017.08.17.15.36.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Aug 2017 15:36:13 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Dibyendu Majumdar , Luc Van Oostenryck Subject: [RFC PATCH 4/4] fix promotion of struct & union Date: Fri, 18 Aug 2017 00:35:58 +0200 Message-Id: <20170817223558.21258-5-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170817223558.21258-1-luc.vanoostenryck@gmail.com> References: <20170817223558.21258-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP --- linearize.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/linearize.c b/linearize.c index 485d8eeec..a92a0e095 100644 --- a/linearize.c +++ b/linearize.c @@ -957,6 +957,8 @@ static int linearize_address_gen(struct entrypoint *ep, */ static inline int is_promotable(struct symbol *type) { + struct symbol *member; + if (type->type == SYM_NODE) type = type->ctype.base_type; switch (type->type) { @@ -967,7 +969,13 @@ static inline int is_promotable(struct symbol *type) return 1; case SYM_STRUCT: case SYM_UNION: - return type->bit_size <= long_ctype.bit_size; + if (type->bit_size > long_ctype.bit_size) + return 0; + FOR_EACH_PTR(type->symbol_list, member) { + if (!is_promotable(member)) + return 0; + } END_FOR_EACH_PTR(member); + return 1; default: break; }