From patchwork Wed Aug 23 20:15:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 9918289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F3AD5602CB for ; Wed, 23 Aug 2017 20:16:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6D6E28A2C for ; Wed, 23 Aug 2017 20:16:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DBDEE28A2E; Wed, 23 Aug 2017 20:16:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F11128A2C for ; Wed, 23 Aug 2017 20:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932643AbdHWUQv (ORCPT ); Wed, 23 Aug 2017 16:16:51 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:37207 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932565AbdHWUQu (ORCPT ); Wed, 23 Aug 2017 16:16:50 -0400 Received: by mail-wm0-f68.google.com with SMTP id v186so631934wmf.4 for ; Wed, 23 Aug 2017 13:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8GjvRV7ohA8/99tDDxVIYS3FZaxZ3VDfD0l23MZgCkY=; b=pNlK9aRL4Aod64o1qpAkK0kUZ/FFqvwMNrMOHr5ezdo8jg35sVpOSdOaLJRbrmSiBj dpYYihPvFpFDSTv+jYakBrckHyNpZpOGS9H0cvOInlwH4YCSaF7Cid5zFn4hjVXups8V Dkq6GmzoTtiK5Vre3i04+bXqadvW7wq2KkCZSs46b3Jag2x9j0mjtc7bOulIQq1waoWi eyDyb/Lqiwv8f+se5xKdmQEnZN9poS/G5jem4d868Lq+WKwlrWW2buvayceABATZkyGx lHPSMRtPzY/lXnwTWAiXq7GcrIVu7MiYwavXt1hMU4/rh6DDK7bAXap4L9XLwWarrw+X ypIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8GjvRV7ohA8/99tDDxVIYS3FZaxZ3VDfD0l23MZgCkY=; b=kHx/UnPCFUoW5SMSwn+k4MpGPfLa6AJ3g3BGQ4oSno/Mb1XD97DJPlSyVuZtQFZLh2 YrZvgaqDg5nyr+VMQLWlqUVFFWyolQa16nnZWnniE+QrdivBcn75hJWmxBBBhTtsR9ls 7z5tGG2GoNCoAi+1c3pkEwXjeIIzeRO0qiSqz2laG3tJ5vE4niwhoEN+i9sxYO2JINRT L9DZOd2Ls3Hk6gzbYlxAZPRg2nSi+PfgQCno0aFio5xQ4Jh6RzJMXSF/zroJkYK2t/Uq EJ202KEAvPVtHC2soJvlJ1OFfvRvsIcjB4oeiHVhxtBlJAWJgL/dKY6Be6ktn7UiSGch mNwQ== X-Gm-Message-State: AHYfb5jrO1cO3JQO3xAZhzJ2fzwPHL2ABYxgkaVpJ18eUKdHkr4MAADh bfKa9LoFYErOKtuAhig= X-Received: by 10.80.162.198 with SMTP id 64mr4023617edm.168.1503519409314; Wed, 23 Aug 2017 13:16:49 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4076:600:9020:103b:7912:3a40]) by smtp.gmail.com with ESMTPSA id e29sm1183374edd.88.2017.08.23.13.16.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Aug 2017 13:16:48 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck Subject: [RFC PATCH 25/48] mem2reg: reorg externaly_visible() returns Date: Wed, 23 Aug 2017 22:15:31 +0200 Message-Id: <20170823201554.90551-26-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170823201554.90551-1-luc.vanoostenryck@gmail.com> References: <20170823201554.90551-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP --- mem2reg.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mem2reg.c b/mem2reg.c index 6fe864df0..a9bf78ed4 100644 --- a/mem2reg.c +++ b/mem2reg.c @@ -247,7 +247,7 @@ static unsigned long externaly_visible(struct symbol *sym, unsigned long mod) struct pseudo_user *pu; if (mod) - goto external_visibility; + return mod; FOR_EACH_PTR(pseudo->users, pu) { /* We know that the symbol-pseudo use is the "src" in the instruction */ @@ -261,8 +261,7 @@ static unsigned long externaly_visible(struct symbol *sym, unsigned long mod) case OP_SYMADDR: if (!insn->bb) continue; - mod |= MOD_ADDRESSABLE; - goto external_visibility; + return MOD_ADDRESSABLE; case OP_NOP: case OP_SNOP: case OP_LNOP: @@ -273,8 +272,7 @@ static unsigned long externaly_visible(struct symbol *sym, unsigned long mod) } } END_FOR_EACH_PTR(pu); -external_visibility: - return mod; + return 0; } static void promote_symbol(struct entrypoint *ep, struct symbol *sym)