From patchwork Fri Sep 1 07:46:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 9933693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6679A6021C for ; Fri, 1 Sep 2017 07:46:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57A3E2857E for ; Fri, 1 Sep 2017 07:46:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B7D428584; Fri, 1 Sep 2017 07:46:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C49812857E for ; Fri, 1 Sep 2017 07:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbdIAHqr (ORCPT ); Fri, 1 Sep 2017 03:46:47 -0400 Received: from arcturus.kleine-koenig.org ([78.47.169.190]:37682 "EHLO arcturus.kleine-koenig.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbdIAHqq (ORCPT ); Fri, 1 Sep 2017 03:46:46 -0400 Received: by arcturus.kleine-koenig.org (Postfix, from userid 1000) id 723EF1A881A; Fri, 1 Sep 2017 09:46:45 +0200 (CEST) Date: Fri, 1 Sep 2017 09:46:44 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Ramsay Jones Cc: Christopher Li , Linux-Sparse , 873508@bugs.debian.org, Antoine Beaupre Subject: Re: sparse test failures on ppc32le (and other not so common archs) Message-ID: <20170901074643.rivm2rit53mavkjr@taurus.defre.kleine-koenig.org> References: <20170830161435.krq44m5zub4mq43x@taurus.defre.kleine-koenig.org> <20170830173652.2s26nti2s2mgupnd@taurus.defre.kleine-koenig.org> <20170831205514.vxmirle2yoc3rm44@taurus.defre.kleine-koenig.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, On Thu, Aug 31, 2017 at 11:43:53PM +0100, Ramsay Jones wrote: > On 31/08/17 21:55, Uwe Kleine-König wrote: > > On Wed, Aug 30, 2017 at 08:11:49PM -0400, Christopher Li wrote: > >> That is very much like on x86_64 missing define "#weak_define __x86_64__ 1" > >> > >> Does cgcc work for you? In the future we do want to move the archetecture > >> related define from cgcc into sparse by itself. For now you can set > >> "sparse" as "cgcc -no-compile" > > > > Yes that works. So to address the Debian bug I can do: > > > > - move sparse to /usr/lib > > - teach cgcc about the move of sparse > > - make /usr/bin/sparse call cgcc -no-compile "$@" > > Hmm, I don't think that would be a good idea ... > > > or is it easier to teach sparse about the architecture stuff? > > I now understand (I think!) that you are building a sparse > package (presumably a .deb) and you are concerned that sparse > does not pass it's own testsuite on those platforms. Nearly right. I'm responsible for the sparse Debian package and the problem at hand is https://bugs.debian.org/873508. This bug report has "Severity: serious" wihch might eventually result in the removal of sparse from the Debian archive. @anarcat: Given that cgcc seems to work, would you agree to apply the following patch to horst: and downgrade the bug to "important"? That would be a compromise that buys us a bit of time. > As I said before, the additional failures you are seeing are > in the 'llvm backend' code (which, as far as I know, only passes > on x86_64 Linux), and in my opinion the llvm-backend programs should > not be installed. (The Makefile will build them automatically if > you have llvm installed, likewise for c2xml/libxml and test-inspect/gtk). Currently the sparse package contains /usr/include/sparse/, c2xml, cgcc, sparse, sparse-llvm, sparsec and a separate package sparse-test-inspect includes test-inspect. (That's how I inherited the package some time ago.) > [I would like to see build variable(s) to allow the user to suppress > the build (or installation) of the other 'non-primary' sparse programs.] > > Anyway, if you were to un-install llvm, sparse-llvm etc., would not > be built, and the tests would not be run ... ;-) > > Christopher, as the project maintainer, has the joy of making these > kinds of decisions! :-D This only solves a part of the problem because the bug report is about sparse itself, not it's llvm part. Best regards Uwe diff --git a/Makefile b/Makefile index 4f924fa..d563652 100644 --- a/Makefile +++ b/Makefile @@ -110,7 +110,7 @@ $(NAME): $(OBJS) $(OBJS): .buildflags check: - sparse $(CFLAGS) *.[ch] + cgcc -no-compile $(CFLAGS) *.[ch] clean: -rm -f *.o radiotap/*.o *~