From patchwork Tue Oct 17 23:31:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacob Keller X-Patchwork-Id: 10013085 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 32011600CC for ; Tue, 17 Oct 2017 23:31:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A3D628A1A for ; Tue, 17 Oct 2017 23:31:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DDA528A22; Tue, 17 Oct 2017 23:31:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA9A428A1A for ; Tue, 17 Oct 2017 23:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759015AbdJQXbj (ORCPT ); Tue, 17 Oct 2017 19:31:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:35996 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755538AbdJQXbi (ORCPT ); Tue, 17 Oct 2017 19:31:38 -0400 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2017 16:31:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,393,1503385200"; d="scan'208";a="324417312" Received: from jekeller-desk.amr.corp.intel.com (HELO jekeller-desk.jekeller.internal) ([134.134.177.230]) by fmsmga004.fm.intel.com with ESMTP; 17 Oct 2017 16:31:38 -0700 From: Jacob Keller To: linux-sparse@vger.kernel.org Cc: Jacob Keller Subject: [PATCH] sparse: document that -Wbitwise is default Date: Tue, 17 Oct 2017 16:31:36 -0700 Message-Id: <20171017233136.24533-1-jacob.e.keller@intel.com> X-Mailer: git-send-email 2.14.1.436.g33e61a4f0239 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit commit 02a886bfa3d9 ("Introduce keyword driven attribute parsing", 2007-03-08) the -Wbitwise keyword was broken and did not actually work. Instead, bitwise checks were always enabled. This was fixed by commit commit 0dfda0d1f0fe ("make -Wbitwise operational again", 2017-02-18) which allowed -Wbitwise and -Wno-bitwise to work as expected. However, since -Wbitwise was enabled for so long, that commit changed the default of -Wbitwise to be enabled, rather than the documented "disabled". Fix the documentation to match, and explain that -Wbitwise is enabled by default and must be disabled. Signed-off-by: Jacob Keller Acked-by: Luc Van Oostenryck --- sparse.1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sparse.1 b/sparse.1 index fd4527aa5c95..bdfe14902ba6 100644 --- a/sparse.1 +++ b/sparse.1 @@ -67,8 +67,8 @@ kind of like "NULL" for pointers). So "gfp_t" or the "safe endianness" types would be __bitwise: you can only operate on them by doing specific operations that know about *that* particular type. -Generally, you want bitwise if you are looking for type safety. Sparse -does not issue these warnings by default. +Sparse issues these warnings by default. To turn them off, use +\fB\-Wno\-bitwise\fR. . .TP .B \-Wcast\-to\-as