From patchwork Tue Jun 26 06:00:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 10487957 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 361DC60386 for ; Tue, 26 Jun 2018 06:02:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26AA728753 for ; Tue, 26 Jun 2018 06:02:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B92828763; Tue, 26 Jun 2018 06:02:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B898A28753 for ; Tue, 26 Jun 2018 06:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbeFZGCQ (ORCPT ); Tue, 26 Jun 2018 02:02:16 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43240 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbeFZGCP (ORCPT ); Tue, 26 Jun 2018 02:02:15 -0400 Received: by mail-ed1-f65.google.com with SMTP id r7-v6so218657edq.10 for ; Mon, 25 Jun 2018 23:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w6VWN82aI7HguSvkkxN1mrP8tb/5YSB61k2rHXX8FuQ=; b=F+zZYFthPurcLxXnuQr+rpLeb4d6awIUsoKb3evo00b0TJK5sktiQBSTEPoPv3sd8G IIxLIHrLBtaVQ7TxI/LCOIfVF4Ipf157ZhE0MZyw3ekfb00nGijZ45COawu4TilA4eIm IeAQF71p6Y7B1+D9DhTLtUOdO3NkHNwdkNNpLTPkMvmktQ95Stcmi2f5OZldBj4Juh9u 1jKN4C2D7Op6G5M0p7OJS8vc74J9zkNRl300RAs6hZ0nrXy/FzbT10LHC8CYfxLGA24I jywcnPLATwA1I5Fli2JR2LhXiw84hKkORqXn5YRQ9r8Q/3U5c162yD++FdHs8Z0WpOsO vYPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w6VWN82aI7HguSvkkxN1mrP8tb/5YSB61k2rHXX8FuQ=; b=CwAA5vrAksxnLF6PY3KJoe2kzoQScEqdElnotNG5QbdH9g9judY23eKkJSBO8LyMQj HOUFiJSo9Zo6I55S3i10Pbj5iFOEyAWpZzOEMA/K0j/kbu163v/8PR3Skfc0HYkwOghf xVHDEXq9AmKyWV6EaNfLCpJg2HVrlWIB+cYrXFyd87xlqs3xOFTNOqEJJkfiVPgcNtFJ zSLSYDr1q4KM2yDS5d/1m1Pu1pPLzM/Dxk4ZT/KgeuoVY5lJRoSXEhZ+UVH/3nqdzU1J XsSx+4/ance3soIYoWITN5DOvXPl2S9QqD08HyPQY1GIpsvnCtaXKdx8Zg0xyS+FQM+n UEng== X-Gm-Message-State: APt69E0RBJW53FEEGbOmmgr6TLNl2QPvBOLkX/uWNj8kmz+lul33Zjp3 /bba5R+6qs5jcHHhBMdjnh1aXNdv X-Google-Smtp-Source: AAOMgpeF7d9Do/p0nR3RHFxSMDHVcjux4k8t5rC6HljEaKj2mkxeZ9h6bZ6yTMXQ+LjYxrwFjIQMdg== X-Received: by 2002:a50:9048:: with SMTP id z8-v6mr514709edz.79.1529992934448; Mon, 25 Jun 2018 23:02:14 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e5:e900:116c:7d04:d147:7604]) by smtp.gmail.com with ESMTPSA id l54-v6sm540443edb.13.2018.06.25.23.02.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 23:02:14 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Luc Van Oostenryck Subject: [PATCH 08/10] bool: simplify 'x != 0' or 'x == 1' to 'x' Date: Tue, 26 Jun 2018 08:00:00 +0200 Message-Id: <20180626060002.35753-9-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180626060002.35753-1-luc.vanoostenryck@gmail.com> References: <20180626060002.35753-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These two comparisons are no-ops when the operand is a bool. Simplify away these comparisons. Signed-off-by: Luc Van Oostenryck --- simplify.c | 7 +++++++ validation/optim/bool-context-fp.c | 6 ++---- validation/optim/bool-simplify2.c | 5 ++--- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/simplify.c b/simplify.c index 9f0d13b55..89532646a 100644 --- a/simplify.c +++ b/simplify.c @@ -625,6 +625,13 @@ static int simplify_seteq_setne(struct instruction *insn, long long value) break; default: + if (def->size == 1 && !inverse) + // Replace: + // setne.1 %r <- %s, $0 + // or: + // seteq.1 %r <- %s, $1 + // by %s + return replace_with_pseudo(insn, old); break; } return 0; diff --git a/validation/optim/bool-context-fp.c b/validation/optim/bool-context-fp.c index c3c2e546c..6c80eeb17 100644 --- a/validation/optim/bool-context-fp.c +++ b/validation/optim/bool-context-fp.c @@ -54,8 +54,7 @@ bfior: fcmpune.1 %r20 <- %arg1, %r19 fcmpune.1 %r23 <- %arg2, %r19 or-bool.1 %r24 <- %r20, %r23 - setne.1 %r26 <- %r24, $0 - ret.1 %r26 + ret.1 %r24 ifior: @@ -76,8 +75,7 @@ bfand: fcmpune.1 %r39 <- %arg1, %r38 fcmpune.1 %r42 <- %arg2, %r38 and-bool.1 %r43 <- %r39, %r42 - setne.1 %r45 <- %r43, $0 - ret.1 %r45 + ret.1 %r43 ifand: diff --git a/validation/optim/bool-simplify2.c b/validation/optim/bool-simplify2.c index 72fc2f2ea..e015fe8ec 100644 --- a/validation/optim/bool-simplify2.c +++ b/validation/optim/bool-simplify2.c @@ -7,7 +7,7 @@ static int foo(int a, int b, int c) * check-name: bool-simplify2 * check-command: test-linearize $file * - * check-output-pattern(4): setne\\. + * check-output-pattern(3): setne\\. * check-output-pattern(1): zext\\. * * check-output-start @@ -17,9 +17,8 @@ foo: setne.1 %r2 <- %arg1, $0 setne.1 %r4 <- %arg2, $0 or-bool.1 %r5 <- %r2, %r4 - setne.1 %r7 <- %r5, $0 setne.1 %r9 <- %arg3, $0 - or-bool.1 %r10 <- %r7, %r9 + or-bool.1 %r10 <- %r5, %r9 zext.32 %r11 <- (1) %r10 ret.32 %r11