diff mbox series

[07/16] cast: fix shift signedness in cast simplification

Message ID 20180721211653.72853-8-luc.vanoostenryck@gmail.com (mailing list archive)
State Mainlined, archived
Headers show
Series casts simplification | expand

Commit Message

Luc Van Oostenryck July 21, 2018, 9:16 p.m. UTC 
In commit c64d1972a ("cast: prepare for more cast simplifications")
a unsigned right shift was inadvertently changed to a signed one.

Restore the correct signedness.

Fixes: c64d1972a ("cast: prepare for more cast simplifications")
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 simplify.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/simplify.c b/simplify.c
index 996b3672e..68195d5f9 100644
--- a/simplify.c
+++ b/simplify.c
@@ -995,7 +995,8 @@  static int simplify_cast(struct instruction *insn)
 		if (def->size >= size) {
 			pseudo_t val = def->src2;
 			if (val->type == PSEUDO_VAL) {
-				if (!(val->value >> (size-1)))
+				unsigned long long value = val->value;
+				if (!(value >> (size-1)))
 					goto simplify;
 			}
 		}