From patchwork Sat Sep 8 00:00:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 10592717 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B1730921 for ; Sat, 8 Sep 2018 00:01:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88FA32B632 for ; Sat, 8 Sep 2018 00:01:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 82CFF2B6E8; Sat, 8 Sep 2018 00:01:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 854572B612 for ; Sat, 8 Sep 2018 00:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbeIHEoZ (ORCPT ); Sat, 8 Sep 2018 00:44:25 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35891 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725734AbeIHEoZ (ORCPT ); Sat, 8 Sep 2018 00:44:25 -0400 Received: by mail-wr1-f68.google.com with SMTP id e1-v6so7386728wrt.3 for ; Fri, 07 Sep 2018 17:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OqSnikjcARIpqu4cGvsdkXFo8DAVFsebfNYIDGVag3M=; b=VFPA4V7jGKbEx6TFby8kx250yButY1gdVqerCGZCN1v57GW7mUG39lJMA87ZcYxJWo EaN2wD9A2zY0aOZ2FRNvOZPGz6wW++A4VOxkXPwyRV2TMKDK33bloXaK+RqmuN1hV9h3 QjTfijYSIsYzJPXkBlTLjuraXY60laHMe5HZ9Xjoc9CLi9UsaXUQX/mjFveDXYQimkzf FFki+/YPJsb2S0MIvUKl66yETgidb34ZFg948UL3PqxEvEk4yd3/IykfeagTF9M8OFgs b9dfnrukFtw2qrPInjxFnql6wDKNJyFNvTkGaATDpOWQOCYKgiJiUjbgenTQuOowymkT pAvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OqSnikjcARIpqu4cGvsdkXFo8DAVFsebfNYIDGVag3M=; b=MssMAv4UmZ9G+UQqKY3tV/2gxDz3AcOEVGJB4Vt5ig9VgYbSsTLnz7BEMwhkXd+Xxh gdWiGg/3vEPG60Tu8AjDAI5egG5lxkwACMn5KrALHpdn3ADA7bAB2WR9k0wXmt53AlUW SmFvBzTLY3dVoidv56EWR3wvjyztNuslUIFZRCI5NtPaGyrlzKyjJh5FD6+Jk2/B0Nyr uBxaNHLQX9FAfGRHE20YXCZgCmnmqpL0mmyRpwyCYDfhaPtKeH9HxqOrF3AjSyfByFAP aGQJbrox4Vsvmf6UM/UgmaxfTryNFCANAuPC4vw4/nOW4ZI2kQ/x3e4HO/mAm1dfcL82 SM7A== X-Gm-Message-State: APzg51DQchG5dIYOXpx9Yfvh+gb6WASoL73XVtm4m/MH1rifTxfz8Tyo JzGIN1Fnt87qp4cBv5QnJUP4tRN3 X-Google-Smtp-Source: ANB0VdayKqmsWKG9IW9Iw9ngXvGhsnIha8/NeVRZPxq1kLwDGj+SUQdwn+Xp3wrfqbJ4NqZjvW3BHw== X-Received: by 2002:adf:9ae5:: with SMTP id a92-v6mr8437957wrc.125.1536364860406; Fri, 07 Sep 2018 17:01:00 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:4006:df00:c856:97f7:a8a9:88f6]) by smtp.gmail.com with ESMTPSA id t132-v6sm12886115wmf.24.2018.09.07.17.00.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 17:00:59 -0700 (PDT) From: Luc Van Oostenryck To: linux-sparse@vger.kernel.org Cc: Christophe Leroy , Luc Van Oostenryck Subject: [PATCH 11/12] enum: warn on bad enums Date: Sat, 8 Sep 2018 02:00:45 +0200 Message-Id: <20180908000046.65842-12-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180908000046.65842-1-luc.vanoostenryck@gmail.com> References: <20180908000046.65842-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP During the parsing of enum definitions, if some invalid type combination is reached, the base type is forced to 'bad_ctype'. Good. However, this is done without a warning and it's only when the enum is used that some sign of a problem may appear, with no hint toward the true cause. Fix this by issuing a warning when the base type becomes invalid. Signed-off-by: Luc Van Oostenryck --- parse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/parse.c b/parse.c index 3bccc6023..41d5fd93a 100644 --- a/parse.c +++ b/parse.c @@ -925,8 +925,10 @@ static struct token *parse_enum_declaration(struct token *token, struct symbol * info(expr->pos, " expected: %s", show_typename(base_type)); info(expr->pos, " got: %s", show_typename(ctype)); base_type = &bad_ctype; - } else + } else if (base_type != &bad_ctype) { + sparse_error(token->pos, "bad enum definition"); base_type = &bad_ctype; + } parent->ctype.base_type = base_type; } if (is_int_type(base_type)) {