From patchwork Sun Oct 21 17:14:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miguel Ojeda X-Patchwork-Id: 10651365 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B696114E2 for ; Sun, 21 Oct 2018 17:14:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A8F6287C2 for ; Sun, 21 Oct 2018 17:14:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A53C287C6; Sun, 21 Oct 2018 17:14:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 298D9287B5 for ; Sun, 21 Oct 2018 17:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbeJVB3m (ORCPT ); Sun, 21 Oct 2018 21:29:42 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51193 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727688AbeJVB3l (ORCPT ); Sun, 21 Oct 2018 21:29:41 -0400 Received: by mail-wm1-f67.google.com with SMTP id i8-v6so7919231wmg.0; Sun, 21 Oct 2018 10:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o3HmxdElEan8PDyuuAhOtrH3RdwB6dQE/RImZWBr3E4=; b=fGMPxMD++IYRW9PSqM0Q0c5C5gDDgu/MQ3QSjFxgZVyqoOJQZLUE5qAf9Dm4a836es ffIaZIgpSJdY5hHIywrpRmJSAohsIxBz4w+bVd/j0nhRfNZIzsj8kueJA91Eou4eV2av i3w82VA1JOokFKI06KpVC0eEvexDsMZ4vqmqrSiO7BkT+PL7HHFnee89XlC/4QZOQmtr HJ1iEGGaoR5uHBZK/bYPnpXQpaiIAiH13GTqyrdsOKKTsXRvfacsazqT43gSdG3i+xXS UBb1McfLljpJEGsVFYKOa3I3sqWi9CC+t4Cj+O+fI/UxJdiaqSaZfVt0Z8QdUgs/5oRk iYQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o3HmxdElEan8PDyuuAhOtrH3RdwB6dQE/RImZWBr3E4=; b=mPyIvorFefokQzKEu6DiRLA1QJNyz8RpkXEQa2nQ+wOiJUFk8b+CIv7wiphcVJW2f5 bwCYHLNtixZdFflbsslb27/hnRvRVkSRsPeJrbyZEBP96wLz4TJuXI8q/zF0dV5UMgQt L/sCPHbZOSsojrDRTWmEAHu5XGKzYnl1IZqXEeLTy5xz/oyAWbWeurUl0gfAfpcCENP4 E3JPIHyTpkXoffpUY3Rh4I+BXj/SSeMNBgoDUkpQRz5O1yR8uGUK5yEsTq3y3/upJZrW s6Q7/Nnon8J2j6RFCflqNMk7IlU7RN9V1haUNiD5v6JOzY5NoOuCfWEbauDkzr1lgnSZ aT8g== X-Gm-Message-State: ABuFfojeHG6ETlICy2qMwKWYrFFgZq5bVkrFKqkHD7hMXjkKvAi/zBFP sXp2o55CLZ3iZhN6twFRTPY= X-Google-Smtp-Source: ACcGV63VoEgw11BkHQDOm+FP4deKD4qzkydCrRtpNdiSmRusJKJ3+/Sz9WCZtw3XDvg+RkEuGvr75A== X-Received: by 2002:a1c:2384:: with SMTP id j126-v6mr12542954wmj.124.1540142081015; Sun, 21 Oct 2018 10:14:41 -0700 (PDT) Received: from localhost.localdomain (62.83.35.8.dyn.user.ono.com. [62.83.35.8]) by smtp.gmail.com with ESMTPSA id y16-v6sm20860113wru.18.2018.10.21.10.14.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Oct 2018 10:14:40 -0700 (PDT) From: Miguel Ojeda To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Miguel Ojeda , Dan Carpenter , Andreas Dilger , Masahiro Yamada , Michal Marek , Steven Rostedt , Mauro Carvalho Chehab , Olof Johansson , Konstantin Ryabitsev , "David S . Miller" , Andrey Ryabinin , Kees Cook , Thomas Gleixner , Ingo Molnar , Paul Lawrence , Sandipan Das , Andrey Konovalov , David Woodhouse , Will Deacon , Philippe Ombredanne , Paul Burton , David Rientjes , Willy Tarreau , Martin Sebor , Christopher Li , Jonathan Corbet , Theodore Ts'o , Geert Uytterhoeven , Rasmus Villemoes , Joe Perches , Arnd Bergmann , Dominique Martinet , Stefan Agner , Luc Van Oostenryck , Nick Desaulniers , Andrew Morton , Linus Torvalds , linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough Date: Sun, 21 Oct 2018 19:14:14 +0200 Message-Id: <20181021171414.22674-3-miguel.ojeda.sandonis@gmail.com> In-Reply-To: <20181021171414.22674-1-miguel.ojeda.sandonis@gmail.com> References: <20181021171414.22674-1-miguel.ojeda.sandonis@gmail.com> Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let gcc know these cases are meant to fall through to the next label by annotating them with the new __fallthrough statement attribute; and remove the comment since it conveys the same information (which was also parsed by gcc to suppress the warning). Signed-off-by: Miguel Ojeda --- drivers/auxdisplay/panel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c index 21b9b2f2470a..0755034e49ba 100644 --- a/drivers/auxdisplay/panel.c +++ b/drivers/auxdisplay/panel.c @@ -1367,7 +1367,7 @@ static void panel_process_inputs(void) break; input->rise_timer = 0; input->state = INPUT_ST_RISING; - /* fall through */ + __fallthrough; case INPUT_ST_RISING: if ((phys_curr & input->mask) != input->value) { input->state = INPUT_ST_LOW; @@ -1380,11 +1380,11 @@ static void panel_process_inputs(void) } input->high_timer = 0; input->state = INPUT_ST_HIGH; - /* fall through */ + __fallthrough; case INPUT_ST_HIGH: if (input_state_high(input)) break; - /* fall through */ + __fallthrough; case INPUT_ST_FALLING: input_state_falling(input); }