From patchwork Sat Oct 11 19:56:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramsay Jones X-Patchwork-Id: 5069731 Return-Path: X-Original-To: patchwork-linux-sparse@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5DB4DC11AC for ; Sat, 11 Oct 2014 19:56:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6FDBA2017D for ; Sat, 11 Oct 2014 19:56:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8ACBB20160 for ; Sat, 11 Oct 2014 19:56:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751224AbaJKT4T (ORCPT ); Sat, 11 Oct 2014 15:56:19 -0400 Received: from mdfmta004.mxout.tch.inty.net ([91.221.169.45]:46162 "EHLO smtp.demon.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751006AbaJKT4S (ORCPT ); Sat, 11 Oct 2014 15:56:18 -0400 Received: from mdfmta004.tch.inty.net (unknown [127.0.0.1]) by mdfmta004.tch.inty.net (Postfix) with ESMTP id B51D9AC40E4; Sat, 11 Oct 2014 20:56:17 +0100 (BST) Received: from mdfmta004.tch.inty.net (unknown [127.0.0.1]) by mdfmta004.tch.inty.net (Postfix) with ESMTP id 72ED8AC40D6; Sat, 11 Oct 2014 20:56:17 +0100 (BST) Received: from [10.0.2.15] (unknown [80.176.147.220]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mdfmta004.tch.inty.net (Postfix) with ESMTP; Sat, 11 Oct 2014 20:56:17 +0100 (BST) Message-ID: <54398B60.9080009@ramsay1.demon.co.uk> Date: Sat, 11 Oct 2014 20:56:16 +0100 From: Ramsay Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Christopher Li CC: Sparse Mailing-list Subject: [PATCH 1/4] test-suite: remove bashism to avoid test failures X-MDF-HostID: 17 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The use of the '==' operator in a test/[ conditional is a non-POSIX bash extension. In order to avoid test failures on systems that do not have bash as the system shell (/bin/sh), replace the use of the '==' operator with the POSIX compatible '=' operator. Signed-off-by: Ramsay Jones --- Hi Chris, Sorry for not spotting this earlier; I just looked at your patch in my email client and thought 'yep, that looks good', without actually testing the change. :( Since Linux Mint is a Ubuntu derivative my /bin/sh is actually dash. (I hear Fedora are looking to change /bin/sh to dash as well. :-D ). ATB, Ramsay Jones validation/test-suite | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/validation/test-suite b/validation/test-suite index 7f0f83e..df5a7c6 100755 --- a/validation/test-suite +++ b/validation/test-suite @@ -114,7 +114,7 @@ do_test() set -- $cmd base_cmd=`basename $1` for i in $disabled_cmds; do - if [ "$i" == "$base_cmd" ] ; then + if [ "$i" = "$base_cmd" ] ; then disabled_tests=`expr $disabled_tests + 1` echo " DISABLE $test_name ($file)" return 3