| Message ID | eaf45a7f-6c3b-34bf-b65b-e23107cd37ae@ramsayjones.plus.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | Subject: [PATCH] lib.c: fix spelling of _BIG_ENDIAN | expand |
On Tue, Nov 12, 2019 at 02:33:40AM +0000, Ramsay Jones wrote: > > Commit 3c3881cf1c ("cgcc: let sparse define _BIG_ENDIAN", 2019-11-08) > moved the definition of the _BIG_ENDIAN macro from cgcc to sparse (for > the powerpc platforms). Unfortunately, the macro was inadvertently spelt > incorrectly (as _BIG_DEBIAN). Correct the spelling. Sigh ... I wonder what was in my mind when I wrote that ... > > Hi Luc, > > Sorry for not noticing this earlier - I still had this patch in my Hi Ramsay, Don't be sorry, really. I'm already very grateful that you noticed it! Thank you. -- Luc
diff --git a/lib.c b/lib.c index fd45da5..52ad0fd 100644 --- a/lib.c +++ b/lib.c @@ -1515,7 +1515,7 @@ static void predefined_macros(void) predefine("__ppc__", 1, "1"); predefine("__PPC__", 1, "1"); if (arch_big_endian) - predefine("_BIG_DEBIAN", 1, "1"); + predefine("_BIG_ENDIAN", 1, "1"); break; case MACH_RISCV64: case MACH_RISCV32:
Commit 3c3881cf1c ("cgcc: let sparse define _BIG_ENDIAN", 2019-11-08) moved the definition of the _BIG_ENDIAN macro from cgcc to sparse (for the powerpc platforms). Unfortunately, the macro was inadvertently spelt incorrectly (as _BIG_DEBIAN). Correct the spelling. Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> --- Hi Luc, Sorry for not noticing this earlier - I still had this patch in my mail client, because I had intended to note the 'beeneeded' typo in the commit message! I didn't notice this typo in the email but, for some reason, I noticed it while reviewing the new commits fetched this afternoon. Ah well, sorry about that. I just did a quick check, before this patch: $ ./sparse --version v0.6.1-29-g781bc5d $ ./sparse --arch=ppc -dM -E -c - </dev/null | grep _BIG_ #define __ORDER_BIG_ENDIAN__ 4321 #define __BIG_ENDIAN__ 1 #define __BYTE_ORDER__ __ORDER_BIG_ENDIAN__ #define _BIG_DEBIAN 1 $ ... after this patch: $ ./sparse --version v0.6.1-30-gded7347 $ ./sparse --arch=ppc -dM -E -c - </dev/null | grep _BIG_ #define __ORDER_BIG_ENDIAN__ 4321 #define __BIG_ENDIAN__ 1 #define __BYTE_ORDER__ __ORDER_BIG_ENDIAN__ #define _BIG_ENDIAN 1 $ ATB, Ramsay Jones lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)