[0/2] convert traceevent into a thread safe library

Message

Tzvetomir Stoyanov Nov. 30, 2018, 1:13 p.m. UTC

This short patch series begins tranformation of libtraceevent into a
thread safe library. It implements per thread local storage for 
tep->last_event cache, and converts input_buf, input_buf_ptr
and input_buf_siz internal variables to be thread specific.

Tzvetomir Stoyanov (2):
  tools/lib/traceevent: make libtraceevent thread safe
  tools/lib/traceevent: make few libtraceevent internal variables to be
    per thread

 tools/lib/traceevent/Build                |  1 +
 tools/lib/traceevent/event-parse-local.h  | 15 ++++--
 tools/lib/traceevent/event-parse-thread.c | 63 +++++++++++++++++++++++
 tools/lib/traceevent/event-parse.c        | 45 ++++++++--------
 4 files changed, 100 insertions(+), 24 deletions(-)
 create mode 100644 tools/lib/traceevent/event-parse-thread.c

Comments

Steven Rostedt Nov. 30, 2018, 4:47 p.m. UTC | #1

On Fri, 30 Nov 2018 13:13:06 +0000
Tzvetomir Stoyanov <[e-mail]> wrote:

> This short patch series begins tranformation of libtraceevent into a
> thread safe library. It implements per thread local storage for 
> tep->last_event cache, and converts input_buf, input_buf_ptr
> and input_buf_siz internal variables to be thread specific.
> 

I've been thinking about this some. And we should change our
development model. We should be pushing these changes into the
trace-cmd tree first.

The reason I wanted to send to Linux tools/lib/traceevent was because
that would open it up to more people in the review stage. But
unfortunately, it leaves us vulnerable to having bugs and unexpected
consequences of these changes.

I think the renames and man pages were fine to go to Linux first. But
now that we are starting to change the way things work, that should go
into trace-cmd first, so that we can have a bit more thorough testing.

Let's get all the patches that have been sent upstream (including my
last patchset I sent to Arnaldo) backported into trace-cmd, and start
doing updates to the trace-cmd repo first. This way we can make sure
the code is tested before we send it to Arnaldo, because I believe they
think we are testing these patches before we send them, and honestly,
we are not.

Sound good?

Note, when writing the patches to trace-cmd, lets continue with the
naming convention "tools/lib/traceevent" just as if we were to be
sending them to Linux.

-- Steve


> Tzvetomir Stoyanov (2):
>   tools/lib/traceevent: make libtraceevent thread safe
>   tools/lib/traceevent: make few libtraceevent internal variables to be
>     per thread
> 
>  tools/lib/traceevent/Build                |  1 +
>  tools/lib/traceevent/event-parse-local.h  | 15 ++++--
>  tools/lib/traceevent/event-parse-thread.c | 63 +++++++++++++++++++++++
>  tools/lib/traceevent/event-parse.c        | 45 ++++++++--------
>  4 files changed, 100 insertions(+), 24 deletions(-)
>  create mode 100644 tools/lib/traceevent/event-parse-thread.c
>