mbox series

[0/2] KernelShark build fixes for v1.0

Message ID 20190611152043.22572-1-ykaradzhov@vmware.com (mailing list archive)
Headers show
Series KernelShark build fixes for v1.0 | expand

Message

Yordan Karadzhov June 11, 2019, 3:20 p.m. UTC 
Two patches addressing the problem of having the paths to the build
directory embedded in the final binaries. The problem was reported
by Troy Engel.

Yordan Karadzhov (2):
  kernel-shark: Avoid TRACECMD_BIN_DIR being set to the build path
  kernel-shark: Avoid debug build when CMAKE_BUILD_TYPE=Release

 kernel-shark/CMakeLists.txt           | 25 ++++++++++++++++---------
 kernel-shark/README                   |  4 ++--
 kernel-shark/build/FindTraceCmd.cmake | 14 +++++++++-----
 kernel-shark/build/deff.h.cmake       |  2 +-
 kernel-shark/src/KsCaptureDialog.cpp  | 13 ++++++++-----
 5 files changed, 36 insertions(+), 22 deletions(-)

Comments

Steven Rostedt June 12, 2019, 1:34 p.m. UTC | #1 
On Tue, 11 Jun 2019 18:20:41 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> Two patches addressing the problem of having the paths to the build
> directory embedded in the final binaries. The problem was reported
> by Troy Engel.

Hi Troy,

Do these patches work for you?

 https://patchwork.kernel.org/patch/10987563/
 https://patchwork.kernel.org/patch/10987565/

If so, can I add our "Tested-by"?

Thanks!

-- Steve

> 
> Yordan Karadzhov (2):
>   kernel-shark: Avoid TRACECMD_BIN_DIR being set to the build path
>   kernel-shark: Avoid debug build when CMAKE_BUILD_TYPE=Release
> 
>  kernel-shark/CMakeLists.txt           | 25 ++++++++++++++++---------
>  kernel-shark/README                   |  4 ++--
>  kernel-shark/build/FindTraceCmd.cmake | 14 +++++++++-----
>  kernel-shark/build/deff.h.cmake       |  2 +-
>  kernel-shark/src/KsCaptureDialog.cpp  | 13 ++++++++-----
>  5 files changed, 36 insertions(+), 22 deletions(-)
>