mbox series

[v2,0/9] (Not so) Minor fixes toward KS 2.0

Message ID 20210428134730.187533-1-y.karadz@gmail.com (mailing list archive)
Headers show
Series (Not so) Minor fixes toward KS 2.0 | expand

Message

Yordan Karadzhov April 28, 2021, 1:47 p.m. UTC 
Yordan Karadzhov (VMware) (9):
  kernel-shark: Fix the build for 32b systems
  kernel-shark: Add "cron" job to workflows
  kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT macro
  kernel-shark: Add cleanup of all plugin contexts
  kernel-shark: Fix memory leak in "sched events" plugin.
  kernel-shark: Disable the pop-up offset dialog
  kernel-shark: Remove kvm_combo from the list of default plugins
  kernel-shark: Remove debugging print out from plugins
  kernel-shark: Hide all plugin internals

 .github/workflows/main.yml   |  5 +++-
 src/KsMainWindow.cpp         | 11 +--------
 src/KsSession.cpp            |  2 +-
 src/libkshark-configio.c     |  2 +-
 src/libkshark-plugin.c       | 10 ++++++++
 src/libkshark-plugin.h       | 47 ++++++++++++++++++++++++++----------
 src/libkshark-tepdata.c      |  3 +--
 src/libkshark.h              |  2 +-
 src/plugins/MissedEvents.cpp |  2 +-
 src/plugins/SchedEvents.cpp  |  5 ++--
 src/plugins/missed_events.c  |  2 --
 src/plugins/sched_events.c   | 47 +++++++++++++++++++++---------------
 src/plugins/sched_events.h   |  3 +--
 tests/libkshark-tests.cpp    |  2 +-
 14 files changed, 87 insertions(+), 56 deletions(-)

Comments

Steven Rostedt May 6, 2021, 6:26 p.m. UTC | #1 
On Wed, 28 Apr 2021 16:47:21 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> Yordan Karadzhov (VMware) (9):
>   kernel-shark: Fix the build for 32b systems
>   kernel-shark: Add "cron" job to workflows
>   kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT macro
>   kernel-shark: Add cleanup of all plugin contexts
>   kernel-shark: Fix memory leak in "sched events" plugin.
>   kernel-shark: Disable the pop-up offset dialog
>   kernel-shark: Remove kvm_combo from the list of default plugins
>   kernel-shark: Remove debugging print out from plugins
>   kernel-shark: Hide all plugin internals
> 

Besides my comment about patch 3, the rest of the patches look fine.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

(For all except for patch 3: "kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT
macro")

-- Steve