| Message ID | 20210514121826.161749-1-y.karadz@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Final fixes before KS 2.0 | expand |
On Fri, 14 May 2021 15:18:19 +0300 "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > Yordan Karadzhov (VMware) (7): > kernel-shark: Preserve markers when appending data > kernel-shark: Preserve open graphs when appending data > kernel-shark: Clear before loading new session > kernel-shark: Better handling of plugins when appending data file > kernel-shark: Do draw the combo point of the mark > kernel-shark: Check if "trace_seq" was destroyed before using it Besides the above patch, the rest look good. Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve > kernel-shark: Quiet the warning printing from libtraceevent > > src/KsDualMarker.hpp | 6 ++++++ > src/KsGLWidget.cpp | 40 ++++++++++++++++++++++++++-------------- > src/KsGLWidget.hpp | 4 +++- > src/KsMainWindow.cpp | 31 ++++++++++++++++++++++++++----- > src/KsPlotTools.cpp | 3 +++ > src/KsSession.cpp | 1 + > src/KsTraceGraph.cpp | 10 +++++++--- > src/KsTraceGraph.hpp | 2 +- > src/KsUtils.cpp | 4 ++-- > src/libkshark-tepdata.c | 16 +++++++++++++++- > 10 files changed, 90 insertions(+), 27 deletions(-) >
On Fri, 14 May 2021 15:18:19 +0300 "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > Yordan Karadzhov (VMware) (7): > kernel-shark: Preserve markers when appending data > kernel-shark: Preserve open graphs when appending data > kernel-shark: Clear before loading new session > kernel-shark: Better handling of plugins when appending data file > kernel-shark: Do draw the combo point of the mark > kernel-shark: Check if "trace_seq" was destroyed before using it > kernel-shark: Quiet the warning printing from libtraceevent > > After applying and testing out this patch set, I realized that the appended file does not have any of its CPUs plotted after it is loaded. -- Steve
On 14.05.21 г. 21:01, Steven Rostedt wrote: > On Fri, 14 May 2021 15:18:19 +0300 > "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > >> Yordan Karadzhov (VMware) (7): >> kernel-shark: Preserve markers when appending data >> kernel-shark: Preserve open graphs when appending data >> kernel-shark: Clear before loading new session >> kernel-shark: Better handling of plugins when appending data file >> kernel-shark: Do draw the combo point of the mark >> kernel-shark: Check if "trace_seq" was destroyed before using it >> kernel-shark: Quiet the warning printing from libtraceevent >> >> > > After applying and testing out this patch set, I realized that the appended > file does not have any of its CPUs plotted after it is loaded. Yes, this is how it works right now. No new plots are added when you append trace file. Do you think it will be to show all CPU plots from the new trace file? Thanks! Yordan > > -- Steve >
On Mon, 17 May 2021 13:22:34 +0300 Yordan Karadzhov <y.karadz@gmail.com> wrote: > On 14.05.21 г. 21:01, Steven Rostedt wrote: > > On Fri, 14 May 2021 15:18:19 +0300 > > "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > > > >> Yordan Karadzhov (VMware) (7): > >> kernel-shark: Preserve markers when appending data > >> kernel-shark: Preserve open graphs when appending data > >> kernel-shark: Clear before loading new session > >> kernel-shark: Better handling of plugins when appending data file > >> kernel-shark: Do draw the combo point of the mark > >> kernel-shark: Check if "trace_seq" was destroyed before using it > >> kernel-shark: Quiet the warning printing from libtraceevent > >> > >> > > > > After applying and testing out this patch set, I realized that the appended > > file does not have any of its CPUs plotted after it is loaded. > > Yes, this is how it works right now. No new plots are added when you > append trace file. > > Do you think it will be to show all CPU plots from the new trace file? > Yeah, I think it is better to see something than nothing. I don't think there's an issue with showing it. Although, if you could automate the kvm combo to be selected by default on appending a file, then you wouldn't need to show the cpu plots of the guest. -- Steve
On 17.05.21 г. 15:54, Steven Rostedt wrote: > On Mon, 17 May 2021 13:22:34 +0300 > Yordan Karadzhov <y.karadz@gmail.com> wrote: > >> On 14.05.21 г. 21:01, Steven Rostedt wrote: >>> On Fri, 14 May 2021 15:18:19 +0300 >>> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: >>> >>>> Yordan Karadzhov (VMware) (7): >>>> kernel-shark: Preserve markers when appending data >>>> kernel-shark: Preserve open graphs when appending data >>>> kernel-shark: Clear before loading new session >>>> kernel-shark: Better handling of plugins when appending data file >>>> kernel-shark: Do draw the combo point of the mark >>>> kernel-shark: Check if "trace_seq" was destroyed before using it >>>> kernel-shark: Quiet the warning printing from libtraceevent >>>> >>>> >>> >>> After applying and testing out this patch set, I realized that the appended >>> file does not have any of its CPUs plotted after it is loaded. >> >> Yes, this is how it works right now. No new plots are added when you >> append trace file. >> >> Do you think it will be to show all CPU plots from the new trace file? >> > > Yeah, I think it is better to see something than nothing. OK, I will send v2 that is doing this. It will be a trivial change. > > I don't think there's an issue with showing it. Although, if you could > automate the kvm combo to be selected by default on appending a file, then > you wouldn't need to show the cpu plots of the guest. This can be done as well but it may be a bit tricky. We should probably also provide a command line option for selecting combo plots. But let's release v2.0 now and keep this feature for v2.1, together with the other features you requested on Bugzilla. Thanks! Yordan > > -- Steve >