mbox series

[v2,0/7] trace-cruncher: Refactor instances and kprobes

Message ID 20210819130827.12327-1-y.karadz@gmail.com (mailing list archive)
Headers show
Series trace-cruncher: Refactor instances and kprobes | expand

Message

Yordan Karadzhov Aug. 19, 2021, 1:08 p.m. UTC
We simplify the way kprobes and tracefs instances are handled by
the Python module.  The need of storing all kprobes and instances
created by the module in a binary search tree is eliminated by
defining new custom Python types for those objects.

Changes in v2:
 - Adding patches [PATCH 3/7, 6/7, 7/7]


Yordan Karadzhov (VMware) (7):
  trace-cruncher: Use proper naming in common.h
  trace-cruncher: Add type checking for the custom Python types
  trace-cruncher: Allow for detachable custom objects
  trace-cruncher: Define Python type for instances
  trace-cruncher: Refactor the way libtracefs instances are handled
  trace-cruncher: Define Python type for kprobes
  trace-cruncher: Refactor the way kprobes are handled

 src/common.h                                  |  34 +-
 src/ftracepy-utils.c                          | 669 +++++++-----------
 src/ftracepy-utils.h                          |  65 +-
 src/ftracepy.c                                | 145 ++--
 tests/1_unit/test_01_ftracepy_unit.py         | 288 +++-----
 .../test_01_ftracepy_integration.py           |  56 +-
 tracecruncher/ft_utils.py                     |  14 +-
 7 files changed, 530 insertions(+), 741 deletions(-)

Comments

Steven Rostedt Aug. 19, 2021, 7:54 p.m. UTC | #1
On Thu, 19 Aug 2021 16:08:20 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> We simplify the way kprobes and tracefs instances are handled by
> the Python module.  The need of storing all kprobes and instances
> created by the module in a binary search tree is eliminated by
> defining new custom Python types for those objects.
> 
> Changes in v2:
>  - Adding patches [PATCH 3/7, 6/7, 7/7]

Hi Yordan,

I took a look over these patches and they all look fine to me.

-- Steve

> 
> 
> Yordan Karadzhov (VMware) (7):
>   trace-cruncher: Use proper naming in common.h
>   trace-cruncher: Add type checking for the custom Python types
>   trace-cruncher: Allow for detachable custom objects
>   trace-cruncher: Define Python type for instances
>   trace-cruncher: Refactor the way libtracefs instances are handled
>   trace-cruncher: Define Python type for kprobes
>   trace-cruncher: Refactor the way kprobes are handled
> 
>  src/common.h                                  |  34 +-
>  src/ftracepy-utils.c                          | 669 +++++++-----------
>  src/ftracepy-utils.h                          |  65 +-
>  src/ftracepy.c                                | 145 ++--
>  tests/1_unit/test_01_ftracepy_unit.py         | 288 +++-----
>  .../test_01_ftracepy_integration.py           |  56 +-
>  tracecruncher/ft_utils.py                     |  14 +-
>  7 files changed, 530 insertions(+), 741 deletions(-)
>