mbox series

[RESEND,0/2] Two tracing patches for trace_events_hist.c

Message ID 20220417185630.199062-1-ammarfaizi2@gnuweeb.org (mailing list archive)
Headers show
Series Two tracing patches for trace_events_hist.c | expand

Message

Ammar Faizi April 17, 2022, 6:56 p.m. UTC 
[ Sorry, this is a resend, I sent it to the wrong address of trace devel list. ]

Hi,

Two patches here.

## Patch 1
If `WARN_ON(!glob)` is ever triggered, we will still continue executing
the next lines. This will trigger the more serious problem, a NULL
pointer dereference bug. Just return -EINVAL if @glob is NULL.

## Patch 2
Change `if (strlen(glob))` to `if (glob[0])`. No need to traverse to
the end of string. If the first byte is not a NUL char, it's
guaranteed `if (strlen(glob))` is true.


Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (2):
  tracing: Return -EINVAL if WARN_ON(!glob) triggered in event_hist_trigger_parse()
  tracing: Change `if (strlen(glob))` to `if (glob[0])`

 kernel/trace/trace_events_hist.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: a1901b464e7e3e28956ae7423db2847dbbfb5be8