mbox series

[v2,0/2] libtraceeval: Remove the need of TRACEEVAL_TYPE_NONE

Message ID 20231003140802.1139616-1-rostedt@goodmis.org (mailing list archive)
Headers show
Series libtraceeval: Remove the need of TRACEEVAL_TYPE_NONE | expand

Message

Steven Rostedt Oct. 3, 2023, 2:08 p.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The use of macros to determine the size of the keys and vals arrays made
me think a bit more about how we initialize the traceeval. The more I'm
using the library, the less I like having to add the TRACEEVAL_TYPE_NONE
to the end of the keys and vals array.

Instead, use the same macro trick of TRACEEVAL_ARRAY_SIZE() to determine
the number of elements. Still allow the use of using the
TRACEEVAL_TYPE_NONE to determine the size (if the number passed in is
still bigger), so that most applications that still use that still work.

I made the change separate than updating the sample code to test that
the old way still works. Then I updated the sample to make sure the new
way works. Perhaps when we add unit tests back in, we'll test both
cases.

Changes since v1: https://lore.kernel.org/linux-trace-devel/20230929100025.1018258-1-rostedt@goodmis.org/

 - Added size checks to check_keys() and check_vals() (Ross Zwisler)

Steven Rostedt (Google) (2):
  libtraceeval: Remove need to use TRACEEVAL_TYPE_NONE in keys and vals
  libtraceeval samples: Remove adding TRACEEVAL_TYPE_NONE to keys and
    vals

 include/traceeval-hist.h | 11 +++++++++--
 samples/task-eval.c      | 18 ------------------
 src/histograms.c         | 23 +++++++++++++----------
 3 files changed, 22 insertions(+), 30 deletions(-)