From patchwork Tue Oct 3 14:08:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13407695 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DF01548D for ; Tue, 3 Oct 2023 14:06:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3534EC433D9; Tue, 3 Oct 2023 14:06:58 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qng4B-004mVE-2W; Tue, 03 Oct 2023 10:08:03 -0400 From: Steven Rostedt To: linux-trace-devel@vger.kernel.org Cc: Ross Zwisler , Stevie Alvarez , "Steven Rostedt (Google)" Subject: [PATCH v2 0/2] libtraceeval: Remove the need of TRACEEVAL_TYPE_NONE Date: Tue, 3 Oct 2023 10:08:00 -0400 Message-Id: <20231003140802.1139616-1-rostedt@goodmis.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-trace-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Steven Rostedt (Google)" The use of macros to determine the size of the keys and vals arrays made me think a bit more about how we initialize the traceeval. The more I'm using the library, the less I like having to add the TRACEEVAL_TYPE_NONE to the end of the keys and vals array. Instead, use the same macro trick of TRACEEVAL_ARRAY_SIZE() to determine the number of elements. Still allow the use of using the TRACEEVAL_TYPE_NONE to determine the size (if the number passed in is still bigger), so that most applications that still use that still work. I made the change separate than updating the sample code to test that the old way still works. Then I updated the sample to make sure the new way works. Perhaps when we add unit tests back in, we'll test both cases. Changes since v1: https://lore.kernel.org/linux-trace-devel/20230929100025.1018258-1-rostedt@goodmis.org/ - Added size checks to check_keys() and check_vals() (Ross Zwisler) Steven Rostedt (Google) (2): libtraceeval: Remove need to use TRACEEVAL_TYPE_NONE in keys and vals libtraceeval samples: Remove adding TRACEEVAL_TYPE_NONE to keys and vals include/traceeval-hist.h | 11 +++++++++-- samples/task-eval.c | 18 ------------------ src/histograms.c | 23 +++++++++++++---------- 3 files changed, 22 insertions(+), 30 deletions(-)