| Message ID | 20240112083945.1361293-1-pierre.gondois@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | trace-cmd: split: Handle splitting files with multiple instances | expand |
On Fri, 12 Jan 2024 09:39:40 +0100 Pierre Gondois <pierre.gondois@arm.com> wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218357 > Hi Pierre! Thanks for sending these. > Splitting trace files having multiple buffer instances discards > side-buffers . I.e., only the main buffer is preserved in the > resulting split trace files. This patch-set intends to fix this. > > Also: > - Fix a side issue preventing to provide start/end timestamps > along with a time-window parameters. > - Update trace-cmd split usage > > Pierre Gondois (5): > trace-cmd: split: Small fixes One small nit, and you do not need to resend for this, but for future patches. You do not need the colon after trace-cmd. That is: trace-cmd split: Small fixes is good enough. In Linux some sub-systems use this method for when a patch affects two sub-systems. <subsystemA>: <subsystemB>: Subject But here it's representing the actual command. "trace-cmd split" is being fixed. > trace-cmd: usage: Update usage for trace-cmd split If just fixing the usage of a single command, I would have that be: trace-cmd split: Update usage to include input file and CPU select -- Steve > trace-cmd: split: Store instances in local list > trace-cmd: split: Add functions to generate temp files > trace-cmd: split: Handle splitting files with multiple instances > > tracecmd/trace-split.c | 231 +++++++++++++++++++++++++++++------------ > tracecmd/trace-usage.c | 3 +- > 2 files changed, 167 insertions(+), 67 deletions(-) >