| Message ID | 20190327160323.31654-2-ykaradzhov@vmware.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | NumPy Interface for KernelShark | expand |
On Wed, 27 Mar 2019 18:03:17 +0200 Yordan Karadzhov <ykaradzhov@vmware.com> wrote: > The function is not meant to have arguments, so it must explicitly > state this. A functions taking unspecified list of parameters will > be a problem for the Pythion interface. I applied this now, because it is a real fix. -- Steve
diff --git a/kernel-shark/src/libkshark-configio.c b/kernel-shark/src/libkshark-configio.c index 2bd5600..9106522 100644 --- a/kernel-shark/src/libkshark-configio.c +++ b/kernel-shark/src/libkshark-configio.c @@ -369,7 +369,7 @@ kshark_filter_config_new(enum kshark_config_formats format) * @returns kshark_config_doc instance on success, otherwise NULL. Use free() * to free the object. */ -struct kshark_config_doc *kshark_string_config_alloc() +struct kshark_config_doc *kshark_string_config_alloc(void) { return kshark_config_alloc(KS_CONFIG_STRING); } diff --git a/kernel-shark/src/libkshark.h b/kernel-shark/src/libkshark.h index a1b1f91..c218b61 100644 --- a/kernel-shark/src/libkshark.h +++ b/kernel-shark/src/libkshark.h @@ -541,7 +541,7 @@ kshark_record_config_new(enum kshark_config_formats); struct kshark_config_doc * kshark_filter_config_new(enum kshark_config_formats); -struct kshark_config_doc *kshark_string_config_alloc(); +struct kshark_config_doc *kshark_string_config_alloc(void); bool kshark_type_check(struct kshark_config_doc *conf, const char *type);
The function is not meant to have arguments, so it must explicitly state this. A functions taking unspecified list of parameters will be a problem for the Pythion interface. Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com> --- kernel-shark/src/libkshark-configio.c | 2 +- kernel-shark/src/libkshark.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)