From patchwork Wed Jul 10 13:46:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11038591 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 85717184E for ; Wed, 10 Jul 2019 13:47:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76B8528900 for ; Wed, 10 Jul 2019 13:47:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B0292891B; Wed, 10 Jul 2019 13:47:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3A4428910 for ; Wed, 10 Jul 2019 13:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbfGJNr1 (ORCPT ); Wed, 10 Jul 2019 09:47:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:56228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfGJNr1 (ORCPT ); Wed, 10 Jul 2019 09:47:27 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59EDF2087F; Wed, 10 Jul 2019 13:47:26 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.92) (envelope-from ) id 1hlCwP-0002p4-Cz; Wed, 10 Jul 2019 09:47:25 -0400 Message-Id: <20190710134725.284088060@goodmis.org> User-Agent: quilt/0.65 Date: Wed, 10 Jul 2019 09:46:38 -0400 From: Steven Rostedt To: linux-trace-devel@vger.kernel.org Cc: Yordan Karadzhov Subject: [PATCH 2/4] kernel-shark: Remove the "make install" suggestion for capture errors References: <20190710134636.116362181@goodmis.org> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Yordan Karadzhov (VMware)" The message is not appropriate, although it is most likely that the error occurs because the user didn't install KernelShark and it runs the executable from its build location. [ Steve: Although I hit this warning without needing a make install ;-) ] Link: http://lore.kernel.org/linux-trace-devel/20190709155650.2345-7-y.karadz@gmail.com Signed-off-by: Yordan Karadzhov (VMware) [ Removed "duplicate" print of it as well ] Signed-off-by: Steven Rostedt (VMware) --- kernel-shark/src/KsMainWindow.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 198b410480a1..13b50795340c 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -1179,7 +1179,6 @@ void KsMainWindow::_captureFinished(int ret, QProcess::ExitStatus st) QString message = "Capture process failed:
"; message += capture->errorString(); - message += "
Try doing:
sudo make install"; _error(message, "captureFinishedErr", false, false); } @@ -1191,8 +1190,6 @@ void KsMainWindow::_captureError(QProcess::ProcessError error) QString message = "Capture process failed:
"; message += capture->errorString(); - message += "
Try doing:
sudo make install"; - _error(message, "captureFinishedErr", false, false); }