diff mbox series

kernel-shark: Xserver, grant access to user root

Message ID 20190725085355.15921-1-tz.stoyanov@gmail.com (mailing list archive)
State Accepted
Commit c9b3aa0c5dedeb554e04406cfe8fadc6dac44699
Headers show
Series kernel-shark: Xserver, grant access to user root | expand

Commit Message

Tzvetomir Stoyanov (VMware) July 25, 2019, 8:53 a.m. UTC 
From: Tzvetomir Stoyanov <tstoyanov@vmware.com>

In order to make connections to the X server, users must be in
the X server allow list. As kernelshark may run with root privileges,
the user "root" must be in this list. There is such logic in
kshark-su-record, but it works only for Wayland X server. Some Linux
distributions use other X servers, so the logic must be executed always.
It grants access to user "root" to initiate connections to the X server from
the local machine.

Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
---
 kernel-shark/bin/kshark-su-record | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/kernel-shark/bin/kshark-su-record b/kernel-shark/bin/kshark-su-record
index 8c9fbd0..c14f03d 100755
--- a/kernel-shark/bin/kshark-su-record
+++ b/kernel-shark/bin/kshark-su-record
@@ -1,9 +1,6 @@ 
 #!/bin/bash
 
-if [ "$XDG_SESSION_TYPE" = "wayland" ]
-then
-    xhost +si:localuser:root &>/dev/null
-fi
+xhost +si:localuser:root &>/dev/null
 
 THIS_DIR=`dirname $0`
 pkexec env DISPLAY=${DISPLAY} ${THIS_DIR}/kshark-record -o ${PWD}/trace.dat