| Message ID | 20191024124139.18459-1-kaslevs@vmware.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix segmentation fault in trace-cmd record on invalid event hooks | expand |
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index c65731f..0596b63 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -4632,6 +4632,8 @@ static void add_hook(struct buffer_instance *instance, const char *arg) struct hook_list *hook; hook = tracecmd_create_event_hook(arg); + if (!hook) + die("Failed to create event hook %s", arg); hook->instance = instance; hook->next = hooks;
Currently passing an invalid event hook to trace-cmd record causes a segmentation fault, e.g. Invalid hook format 'foobar' Segmentation fault Fix this by checking the return value of tracecmd_create_event_hook(). Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com> --- tracecmd/trace-record.c | 2 ++ 1 file changed, 2 insertions(+)