| Message ID | 20191115113610.21493-1-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] libtraceevent: fix lib installation | expand |
Hi Steve, On Fri, Nov 15, 2019 at 11:36 AM Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > When we use 'O=' with make to build libtraceevent in a separate folder > it fails to install libtraceevent.a and libtraceevent.so.1.1.0 with the > error: > INSTALL /home/sudip/linux/obj-trace/libtraceevent.a > INSTALL /home/sudip/linux/obj-trace/libtraceevent.so.1.1.0 > cp: cannot stat 'libtraceevent.a': No such file or directory > Makefile:225: recipe for target 'install_lib' failed > make: *** [install_lib] Error 1 > > I used the command: > make O=../../../obj-trace DESTDIR=~/test prefix==/usr install > > It turns out libtraceevent Makefile, even though it builds in a separate > folder, searches for libtraceevent.a and libtraceevent.so.1.1.0 in its > source folder. > So, add the 'OUTPUT' prefix to the source path so that 'make' looks for > the files in the correct place. > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > --- > tools/lib/traceevent/Makefile | 1 + A gentle ping. I know its the merge window now. But your ack for these two patches will allow me to start with the debian workflow. -- Regards Sudip
On Mon, 2 Dec 2019 12:40:49 +0000 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > Hi Steve, > > On Fri, Nov 15, 2019 at 11:36 AM Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > > > When we use 'O=' with make to build libtraceevent in a separate folder > > it fails to install libtraceevent.a and libtraceevent.so.1.1.0 with the > > error: > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.a > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.so.1.1.0 > > cp: cannot stat 'libtraceevent.a': No such file or directory > > Makefile:225: recipe for target 'install_lib' failed > > make: *** [install_lib] Error 1 > > > > I used the command: > > make O=../../../obj-trace DESTDIR=~/test prefix==/usr install > > > > It turns out libtraceevent Makefile, even though it builds in a separate > > folder, searches for libtraceevent.a and libtraceevent.so.1.1.0 in its > > source folder. > > So, add the 'OUTPUT' prefix to the source path so that 'make' looks for > > the files in the correct place. > > > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > > --- > > tools/lib/traceevent/Makefile | 1 + > > A gentle ping. > I know its the merge window now. But your ack for these two patches will allow > me to start with the debian workflow. > Thanks for the reminder. Yeah, these look fine, and I just tested them out. Arnaldo, can you take these in, and possibly get them into this merge window? Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve
Em Mon, Dec 02, 2019 at 05:53:07PM -0500, Steven Rostedt escreveu: > On Mon, 2 Dec 2019 12:40:49 +0000 > Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > > Hi Steve, > > > > On Fri, Nov 15, 2019 at 11:36 AM Sudip Mukherjee > > <sudipm.mukherjee@gmail.com> wrote: > > > > > > When we use 'O=' with make to build libtraceevent in a separate folder > > > it fails to install libtraceevent.a and libtraceevent.so.1.1.0 with the > > > error: > > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.a > > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.so.1.1.0 > > > cp: cannot stat 'libtraceevent.a': No such file or directory > > > Makefile:225: recipe for target 'install_lib' failed > > > make: *** [install_lib] Error 1 > > > > > > I used the command: > > > make O=../../../obj-trace DESTDIR=~/test prefix==/usr install > > > > > > It turns out libtraceevent Makefile, even though it builds in a separate > > > folder, searches for libtraceevent.a and libtraceevent.so.1.1.0 in its > > > source folder. > > > So, add the 'OUTPUT' prefix to the source path so that 'make' looks for > > > the files in the correct place. > > > > > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > > > --- > > > tools/lib/traceevent/Makefile | 1 + > > > > A gentle ping. > > I know its the merge window now. But your ack for these two patches will allow > > me to start with the debian workflow. > > > > Thanks for the reminder. Yeah, these look fine, and I just tested them > out. > > Arnaldo, can you take these in, and possibly get them into this merge > window? > > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Sure, - Arnaldo
diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile index cbb429f55062..83446fe2cf01 100644 --- a/tools/lib/traceevent/Makefile +++ b/tools/lib/traceevent/Makefile @@ -97,6 +97,7 @@ EVENT_PARSE_VERSION = $(EP_VERSION).$(EP_PATCHLEVEL).$(EP_EXTRAVERSION) LIB_TARGET = libtraceevent.a libtraceevent.so.$(EVENT_PARSE_VERSION) LIB_INSTALL = libtraceevent.a libtraceevent.so* +LIB_INSTALL := $(addprefix $(OUTPUT),$(LIB_INSTALL)) INCLUDES = -I. -I $(srctree)/tools/include $(CONFIG_INCLUDES)
When we use 'O=' with make to build libtraceevent in a separate folder it fails to install libtraceevent.a and libtraceevent.so.1.1.0 with the error: INSTALL /home/sudip/linux/obj-trace/libtraceevent.a INSTALL /home/sudip/linux/obj-trace/libtraceevent.so.1.1.0 cp: cannot stat 'libtraceevent.a': No such file or directory Makefile:225: recipe for target 'install_lib' failed make: *** [install_lib] Error 1 I used the command: make O=../../../obj-trace DESTDIR=~/test prefix==/usr install It turns out libtraceevent Makefile, even though it builds in a separate folder, searches for libtraceevent.a and libtraceevent.so.1.1.0 in its source folder. So, add the 'OUTPUT' prefix to the source path so that 'make' looks for the files in the correct place. Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> --- tools/lib/traceevent/Makefile | 1 + 1 file changed, 1 insertion(+)