| Message ID | 20200424092749.638101-1-tz.stoyanov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6bc13cbbd203df952edb16894788b268bdcff562 |
| Delegated to: | Steven Rostedt |
| Headers | show |
| Series | trace-cmd: Do not enable timestamps synchronization by default | expand |
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index 55c3d80a..25422755 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -2191,8 +2191,6 @@ static void tsync_offset_load(struct tracecmd_input *handle, char *buf) host->ts_samples[j++] = host->ts_samples[i]; } host->ts_samples_count = j; - if (j) - host->sync_enable = true; } static void tsync_check_enable(struct tracecmd_input *handle)
When a timestamps synchronization data is detected in the trace file options, and if this data is valid - timestamps correction is enabled by default. This behavior was for PoC stage of the patches and should not be used in the final version. Timestamps synchronization should be enabled only if the file is opened together with a file from the same tracing session. A new APIs were introduced and already merged upstream for pairing peers from the same session. There is a KernelShark patch which uses those new APIs to pair peers from the same session, when loading the tracing files. The default behavior, indented to be used for the PoC should be removed. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --- lib/trace-cmd/trace-input.c | 2 -- 1 file changed, 2 deletions(-)