diff mbox series

trace-cmd: Have cunit check in Makefile write to /dev/null

Message ID 20201210125858.0de1f116@gandalf.local.home (mailing list archive)
State Accepted
Commit 4b17d24e34673a914eda2367bc8be2c0dc01478b
Headers show
Series trace-cmd: Have cunit check in Makefile write to /dev/null | expand

Commit Message

Steven Rostedt Dec. 10, 2020, 5:58 p.m. UTC 
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

The cunit test in the Makefile does a compile test to check if the cunit
package is installed or not. But it does not have a "-o" option, and thus
will write the result to "a.out" leaving the "a.out" in the source
directory. By adding "-o /dev/null" to the compile check, it will write the
output to /dev/null and not leave an extra executable around.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 022b7c3d..3334d92c 100644
--- a/Makefile
+++ b/Makefile
@@ -263,7 +263,7 @@  ifeq ($(VSOCK_DEFINED), 1)
 CFLAGS += -DVSOCK
 endif
 
-CUNIT_INSTALLED := $(shell if (printf "$(pound)include <CUnit/Basic.h>\n void main(){CU_initialize_registry();}" | $(CC) -x c - -lcunit >/dev/null 2>&1) ; then echo 1; else echo 0 ; fi)
+CUNIT_INSTALLED := $(shell if (printf "$(pound)include <CUnit/Basic.h>\n void main(){CU_initialize_registry();}" | $(CC) -o /dev/null -x c - -lcunit >/dev/null 2>&1) ; then echo 1; else echo 0 ; fi)
 export CUNIT_INSTALLED
 
 export CFLAGS