diff mbox series

trace-cmd: Fix SEGFAULT when no tsync_protos are supplied

Message ID 20210203171018.5b82a0a7@gandalf.local.home (mailing list archive)
State Accepted
Commit 20a39be82bcc257a50cc36440a67698b56cad535
Headers show
Series trace-cmd: Fix SEGFAULT when no tsync_protos are supplied | expand

Commit Message

Steven Rostedt Feb. 3, 2021, 10:10 p.m. UTC 
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

The make_trace_resp() function takes in a tsync_proto string to add to the
message being sent. But if NULL is passed in, the call to strncpy() will
crash.

Just set it to a empty string, and pass that instead.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 lib/trace-cmd/trace-msg.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c
index 611af2c1..79c1b8a1 100644
--- a/lib/trace-cmd/trace-msg.c
+++ b/lib/trace-cmd/trace-msg.c
@@ -1248,6 +1248,9 @@  static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus,
 {
 	int data_size;
 
+	if (!tsync_proto)
+		tsync_proto = "";
+
 	data_size = write_uints(NULL, 0, ports, nr_cpus);
 	msg->buf = malloc(data_size);
 	if (!msg->buf)