| Message ID | 20210302101653.377770-1-tz.stoyanov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0bdeb1b50ba948ddb4ab29085e2a68b8d2ec9ac8 |
| Headers | show |
| Series | trace-cmd: Fix trace-cmd split command | expand |
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c index 7c9863d4..8366d128 100644 --- a/tracecmd/trace-split.c +++ b/tracecmd/trace-split.c @@ -384,10 +384,6 @@ static double parse_file(struct tracecmd_input *handle, for (cpu = 0; cpu < cpus; cpu ++) cpu_list[cpu] = cpu_data[cpu].file; - /* TODO: Fix me, this is suppose to come from handle */ - if (tracecmd_write_cmdlines(ohandle)) - die("Writing cmdlines"); - tracecmd_append_cpu_data(ohandle, cpus, cpu_list); current = end;
The trace-cmd split command seems to be broken with the changes moving the writing of saved_cmdlines after the trace session. The call to tracecmd_write_cmdlines() is no more needed in this command context, the cmdlines should be copied from input to output files. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --- This patch depends on "trace-cmd: Fixes for trace-cmd restore" patch set. tracecmd/trace-split.c | 4 ---- 1 file changed, 4 deletions(-)