| Message ID | 20210311131221.13600-1-michal.sojka@cvut.cz (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | kernel-shark: Do not hardcode /usr prefix for polkit policies | expand |
On Thu, 11 Mar 2021 14:12:21 +0100 Michal Sojka <michal.sojka@cvut.cz> wrote: Hi Michal, Thanks for the fix! Note, even when submitting an "obvious" patch, it's always good to add some content to the change log body. Basically, why it shouldn't be hard coded. That is, what failed because of it. I can think of a few things, but we try to have content in the change log body for all commits, even obvious ones. The only exception is spelling fixes don't need content. Thanks! -- Steve > --- > kernel-shark/src/CMakeLists.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel-shark/src/CMakeLists.txt b/kernel-shark/src/CMakeLists.txt > index 457c100..687e150 100644 > --- a/kernel-shark/src/CMakeLists.txt > +++ b/kernel-shark/src/CMakeLists.txt > @@ -92,7 +92,7 @@ if (Qt5Widgets_FOUND AND Qt5Network_FOUND) > DESTINATION ${_INSTALL_PREFIX}/share/icons/${KS_APP_NAME}) > > install(FILES "${KS_DIR}/org.freedesktop.kshark-record.policy" > - DESTINATION /usr/share/polkit-1/actions/) > + DESTINATION ${_INSTALL_PREFIX}/share/polkit-1/actions/) > > install(PROGRAMS "${KS_DIR}/bin/kshark-su-record" > DESTINATION ${_INSTALL_PREFIX}/bin/)
Hi Steven, On Thu, Mar 11 2021, Steven Rostedt wrote: > On Thu, 11 Mar 2021 14:12:21 +0100 > Michal Sojka <michal.sojka@cvut.cz> wrote: > > Hi Michal, > > Thanks for the fix! > > Note, even when submitting an "obvious" patch, it's always good to add > some content to the change log body. Understood. Sending v2... -Michal
diff --git a/kernel-shark/src/CMakeLists.txt b/kernel-shark/src/CMakeLists.txt index 457c100..687e150 100644 --- a/kernel-shark/src/CMakeLists.txt +++ b/kernel-shark/src/CMakeLists.txt @@ -92,7 +92,7 @@ if (Qt5Widgets_FOUND AND Qt5Network_FOUND) DESTINATION ${_INSTALL_PREFIX}/share/icons/${KS_APP_NAME}) install(FILES "${KS_DIR}/org.freedesktop.kshark-record.policy" - DESTINATION /usr/share/polkit-1/actions/) + DESTINATION ${_INSTALL_PREFIX}/share/polkit-1/actions/) install(PROGRAMS "${KS_DIR}/bin/kshark-su-record" DESTINATION ${_INSTALL_PREFIX}/bin/)