diff mbox series

trace-cmd: Fix double free in tsync_agent_thread()

Message ID 20210331170503.3a9934f5@gandalf.local.home (mailing list archive)
State Superseded
Headers show
Series trace-cmd: Fix double free in tsync_agent_thread() | expand

Commit Message

Steven Rostedt March 31, 2021, 9:05 p.m. UTC 
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

tracecmd_tsync_free() already frees the tsync, remove the free of it after
that is called.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 lib/trace-cmd/trace-timesync.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Steven Rostedt March 31, 2021, 9:48 p.m. UTC | #1 
On Wed, 31 Mar 2021 17:05:03 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> 
> tracecmd_tsync_free() already frees the tsync, remove the free of it after
> that is called.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
>  lib/trace-cmd/trace-timesync.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c
> index e860c335..ad73f08f 100644
> --- a/lib/trace-cmd/trace-timesync.c
> +++ b/lib/trace-cmd/trace-timesync.c
> @@ -887,7 +887,6 @@ static void *tsync_agent_thread(void *data)
>  out:
>  	tracecmd_msg_handle_close(tsync->msg_handle);
>  	tracecmd_tsync_free(tsync);
> -	free(tsync);
>  	close(sd);
>  

Debugging this more, this entire ending is wrong. New patch coming.

-- Steve

>  	pthread_exit(0);
diff mbox series

Patch

diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c
index e860c335..ad73f08f 100644
--- a/lib/trace-cmd/trace-timesync.c
+++ b/lib/trace-cmd/trace-timesync.c
@@ -887,7 +887,6 @@  static void *tsync_agent_thread(void *data)
 out:
 	tracecmd_msg_handle_close(tsync->msg_handle);
 	tracecmd_tsync_free(tsync);
-	free(tsync);
 	close(sd);
 
 	pthread_exit(0);