| Message ID | 20210423232648.1197063-1-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 193a4277485a2fdf139d8d5319594dec55a6abba |
| Headers | show |
| Series | libtracefs: use mode with open() | expand |
On Sat, Apr 24, 2021 at 2:27 AM Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > If -D_FORTIFY_SOURCE=2 is mentioned as a buildflag then the build fails > with the error: > In function ‘open’, > inlined from ‘copy_trace_file’ at tracefs-utest.c:1032:10: > error: call to ‘__open_missing_mode’ declared with attribute error: > open with O_CREAT or O_TMPFILE in second argument needs 3 arguments > > Mention the permission with open() when O_CREAT is mentioned. > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Thanks Sudip! Acked-by: Tzvetomir Stoyanov <tz.stoyanov@gmail.com> > --- > utest/tracefs-utest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c > index edb3a3d..0965363 100644 > --- a/utest/tracefs-utest.c > +++ b/utest/tracefs-utest.c > @@ -1061,7 +1061,7 @@ static void copy_trace_file(const char *from, char *to) > fd_from = open(from, O_RDONLY); > if (fd_from < 0) > goto out; > - fd_to = open(to, O_WRONLY | O_TRUNC | O_CREAT); > + fd_to = open(to, O_WRONLY | O_TRUNC | O_CREAT, S_IRWXU | S_IRWXG); > if (fd_to < 0) > goto out; > > -- > 2.30.2 > -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c index edb3a3d..0965363 100644 --- a/utest/tracefs-utest.c +++ b/utest/tracefs-utest.c @@ -1061,7 +1061,7 @@ static void copy_trace_file(const char *from, char *to) fd_from = open(from, O_RDONLY); if (fd_from < 0) goto out; - fd_to = open(to, O_WRONLY | O_TRUNC | O_CREAT); + fd_to = open(to, O_WRONLY | O_TRUNC | O_CREAT, S_IRWXU | S_IRWXG); if (fd_to < 0) goto out;
If -D_FORTIFY_SOURCE=2 is mentioned as a buildflag then the build fails with the error: In function ‘open’, inlined from ‘copy_trace_file’ at tracefs-utest.c:1032:10: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments Mention the permission with open() when O_CREAT is mentioned. Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> --- utest/tracefs-utest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)