| Message ID | 20210428134730.187533-8-y.karadz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9b20a9afe4f74ac950b2fd022ba1bbb6b771fa2b |
| Headers | show |
| Series | (Not so) Minor fixes toward KS 2.0 | expand |
On Wed, 28 Apr 2021 16:47:28 +0300 "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > The "kvm_combo" plugin is still under tests and is yet to be added to > KernelShark. For the moment we remove it from the list of default > plugins for "tep" data, so that no warning message is being printed. I'm looking forward to where we can put this back to the default. Which reminds me. I see the other two plugins you posted patches for, have you posted the KVM combo one yet? -- Steve > > Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> > --- > src/libkshark-tepdata.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libkshark-tepdata.c b/src/libkshark-tepdata.c > index bc5babb..f7cd083 100644 > --- a/src/libkshark-tepdata.c > +++ b/src/libkshark-tepdata.c > @@ -1210,7 +1210,6 @@ static void kshark_tep_init_methods(struct kshark_generic_stream_interface *inte > const char *tep_plugin_names[] = { > "sched_events", > "missed_events", > - "kvm_combo", > }; > > /**
On 6.05.21 г. 21:25, Steven Rostedt wrote: > On Wed, 28 Apr 2021 16:47:28 +0300 > "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > >> The "kvm_combo" plugin is still under tests and is yet to be added to >> KernelShark. For the moment we remove it from the list of default >> plugins for "tep" data, so that no warning message is being printed. > > I'm looking forward to where we can put this back to the default. > > Which reminds me. I see the other two plugins you posted patches for, > have you posted the KVM combo one yet? Hi Steven, KVM combo is almost ready for posting. It is coming soon. Y. > > -- Steve > >> >> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> >> --- >> src/libkshark-tepdata.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/libkshark-tepdata.c b/src/libkshark-tepdata.c >> index bc5babb..f7cd083 100644 >> --- a/src/libkshark-tepdata.c >> +++ b/src/libkshark-tepdata.c >> @@ -1210,7 +1210,6 @@ static void kshark_tep_init_methods(struct kshark_generic_stream_interface *inte >> const char *tep_plugin_names[] = { >> "sched_events", >> "missed_events", >> - "kvm_combo", >> }; >> >> /** >
diff --git a/src/libkshark-tepdata.c b/src/libkshark-tepdata.c index bc5babb..f7cd083 100644 --- a/src/libkshark-tepdata.c +++ b/src/libkshark-tepdata.c @@ -1210,7 +1210,6 @@ static void kshark_tep_init_methods(struct kshark_generic_stream_interface *inte const char *tep_plugin_names[] = { "sched_events", "missed_events", - "kvm_combo", }; /**
The "kvm_combo" plugin is still under tests and is yet to be added to KernelShark. For the moment we remove it from the list of default plugins for "tep" data, so that no warning message is being printed. Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> --- src/libkshark-tepdata.c | 1 - 1 file changed, 1 deletion(-)