diff mbox series

libtracefs: Rename GR and NQ to GT and NE respectively

Message ID 20210727235348.0faf542e@oasis.local.home (mailing list archive)
State Accepted
Headers show
Series libtracefs: Rename GR and NQ to GT and NE respectively | expand

Commit Message

Steven Rostedt July 28, 2021, 3:53 a.m. UTC 
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

When writing the sqlhist interface, I found that calling ">" GT and "!="
NE were more sensible than calling them GR and NQ, as we already have LT
as "less than" why not use GT as "greater than". As well as EQ for
"equal", it seems more appropriate to have NE be "not equal".

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 include/tracefs.h  | 4 ++--
 src/tracefs-hist.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/include/tracefs.h b/include/tracefs.h
index 25d99f8..445c96f 100644
--- a/include/tracefs.h
+++ b/include/tracefs.h
@@ -315,8 +315,8 @@  enum tracefs_synth_calc {
 
 enum tracefs_synth_compare {
 	TRACEFS_COMPARE_EQ,
-	TRACEFS_COMPARE_NQ,
-	TRACEFS_COMPARE_GR,
+	TRACEFS_COMPARE_NE,
+	TRACEFS_COMPARE_GT,
 	TRACEFS_COMPARE_GE,
 	TRACEFS_COMPARE_LT,
 	TRACEFS_COMPARE_LE,
diff --git a/src/tracefs-hist.c b/src/tracefs-hist.c
index 969944a..8178725 100644
--- a/src/tracefs-hist.c
+++ b/src/tracefs-hist.c
@@ -1201,7 +1201,7 @@  static int add_synth_filter(char **filter, const char *field,
 
 	switch (compare) {
 	case TRACEFS_COMPARE_EQ: trace_seq_puts(&seq, " == "); break;
-	case TRACEFS_COMPARE_NQ: trace_seq_puts(&seq, " != "); break;
+	case TRACEFS_COMPARE_NE: trace_seq_puts(&seq, " != "); break;
 	case TRACEFS_COMPARE_RE:
 		if (!is_string)
 			goto inval;
@@ -1213,7 +1213,7 @@  static int add_synth_filter(char **filter, const char *field,
 	}
 
 	switch (compare) {
-	case TRACEFS_COMPARE_GR: trace_seq_puts(&seq, " > "); break;
+	case TRACEFS_COMPARE_GT: trace_seq_puts(&seq, " > "); break;
 	case TRACEFS_COMPARE_GE: trace_seq_puts(&seq, " >= "); break;
 	case TRACEFS_COMPARE_LT: trace_seq_puts(&seq, " < "); break;
 	case TRACEFS_COMPARE_LE: trace_seq_puts(&seq, " <= "); break;