From patchwork Fri Aug 20 21:03:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John 'Warthog9' Hawley X-Patchwork-Id: 12450477 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544A0C4338F for ; Fri, 20 Aug 2021 21:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33460610CC for ; Fri, 20 Aug 2021 21:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240240AbhHTVED (ORCPT ); Fri, 20 Aug 2021 17:04:03 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51046 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231171AbhHTVED (ORCPT ); Fri, 20 Aug 2021 17:04:03 -0400 Received: from usagi.middle.earth (ethbase.usagi.not.afront.org [IPv6:2620:137:e001:0:1897:4108:901b:c660]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 1AF744D0F1494; Fri, 20 Aug 2021 14:03:25 -0700 (PDT) Received: from usagi.middle.earth (localhost [IPv6:::1]) by usagi.middle.earth (Postfix) with ESMTP id AEFF229AE448; Fri, 20 Aug 2021 14:03:24 -0700 (PDT) From: "John 'Warthog9' Hawley (VMware)" To: rostedt@goodmis.org, linux-trace-devel@vger.kernel.org Subject: [PATCH] sqlhist - fix build dependency Date: Fri, 20 Aug 2021 14:03:24 -0700 Message-Id: <20210820210324.1402616-1-warthog9@eaglescrag.net> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Fri, 20 Aug 2021 14:03:25 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Minor race condition (that's shockingly hard to reproduce, though nearly always reproducible in an rpmbuild) with sqlhist.tab.h being built after it's needed by tracefs-sqlhist.c. This just sets an explicit dependency for tracefs-sqlhist.o on sqlhist.tab.h existing first Signed-off-by: John 'Warthog9' Hawley (VMware) --- src/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Makefile b/src/Makefile index 9248efc..f209bbb 100644 --- a/src/Makefile +++ b/src/Makefile @@ -53,6 +53,8 @@ $(DEPS): $(bdir)/.%.d: %.c $(OBJS): $(bdir)/%.o : $(bdir)/.%.d +tracefs-sqlhist.o: sqlhist.tab.h + $(OBJS): | $(bdir) $(DEPS): | $(bdir)