From patchwork Thu Nov 11 15:11:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 12615097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF40BC433FE for ; Thu, 11 Nov 2021 15:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C538361284 for ; Thu, 11 Nov 2021 15:12:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233994AbhKKPO4 (ORCPT ); Thu, 11 Nov 2021 10:14:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233989AbhKKPOz (ORCPT ); Thu, 11 Nov 2021 10:14:55 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7299AC061766 for ; Thu, 11 Nov 2021 07:12:06 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id b15so25225707edd.7 for ; Thu, 11 Nov 2021 07:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0UHDeOsY2GloB7q9msVpOoxnu8GKfP9mRvkmC/6VgNc=; b=gu3wUWk8Vx28uJBZ6zsqGETFevggCXwz01YyCRxrJzqdiA03zcz/sNZbUe7PUWmMOf dI0JJLMIic/HP932kYU1NUn4OJKvPHKyxBtwC/i339P5qsPSrxHtHz3CEmNPNFmL7HzC PoXY1/BVarj1X4Y6Dgi90iLTXm8OAO/raRyFmoIBdLQsk5whuQeijWv7elgflxg3dotc kQtYc23cUKfWRkB3mGSqa9ZQ+kfErbmRzNB5nG4FqqP+qKNyXA78SLIqoqXpuDKVwfZo SyWpzkpLCZbCoQky0OpKVVQoGymjSyajUN0O5E/8iV5B+ZHnsBdMMoWQKWsJBJ6CycGV priA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0UHDeOsY2GloB7q9msVpOoxnu8GKfP9mRvkmC/6VgNc=; b=SxCQvN3TQrAFaicK8yfbey6h8GIe5hhFA2I/5IwVf47WrHgvJmQs4T0v77WjEJzCiL asn5uBMcDEnQFCE2zHhr0gf1qrnDLo7VfYJbFPGV1ShPtu98hfo7fVasO8mcov8+rdcb sR5Ty5I/sk3BxY0RpgwuLBXdkX20MsyTncmGW/pLlq9Pu19hrC1nmF4sNDKdLHM8YYGn Mjf3oCTdoSXrfHvSkakwC3zu/bE0bQIDmAoBerYpcBLwUUSlb7fsWTlVY+ZWeCu0N0EJ eHciPao8zCRF0U84xtQnEwcAsFjba9HUEoC13ReIipq7AVlmKrYW0atPo49XIPgEc9UY 0bSQ== X-Gm-Message-State: AOAM533oBUUtEGYU2RiXLkI5IbjN80JhzGDfVjBTtvlSzyWaAtizk3LP YfS1ts7aJVcI2vhrqEtGUWVE2wmJX1I1TQ== X-Google-Smtp-Source: ABdhPJxQ0vxMK8e0z3j5W3My9e6l56+P/kIneAgST3e3sZ5rTLw7QuG4+gXge+/YM3wTkSG4qeCEnw== X-Received: by 2002:a05:6402:2743:: with SMTP id z3mr10679718edd.167.1636643525004; Thu, 11 Nov 2021 07:12:05 -0800 (PST) Received: from oberon.zico.biz.zico.biz ([83.222.187.186]) by smtp.gmail.com with ESMTPSA id qf9sm1479509ejc.18.2021.11.11.07.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 07:12:04 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v4 08/20] trace-cmd library: Add local helper function for data compression Date: Thu, 11 Nov 2021 17:11:41 +0200 Message-Id: <20211111151153.86855-9-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211111151153.86855-1-tz.stoyanov@gmail.com> References: <20211111151153.86855-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org The newly added helper functions read data from a file and compress it, before writing into the trace file. The trace data is compressed in chunks, which are page aligned. A new local define is introduced: PAGES_IN_CHUNK which can be used to tune how big a compression chunk is. Signed-off-by: Tzvetomir Stoyanov (VMware) --- lib/trace-cmd/trace-output.c | 71 +++++++++++++++++++++++++++++++++--- 1 file changed, 65 insertions(+), 6 deletions(-) diff --git a/lib/trace-cmd/trace-output.c b/lib/trace-cmd/trace-output.c index 8319d1de..627805a7 100644 --- a/lib/trace-cmd/trace-output.c +++ b/lib/trace-cmd/trace-output.c @@ -283,18 +283,27 @@ static unsigned long get_size(const char *file) return size; } -static tsize_t copy_file_fd(struct tracecmd_output *handle, int fd) +static tsize_t copy_file_fd(struct tracecmd_output *handle, int fd, unsigned long long max) { + tsize_t rsize = BUFSIZ; tsize_t size = 0; char buf[BUFSIZ]; stsize_t r; do { - r = read(fd, buf, BUFSIZ); + if (max && rsize > max) + rsize = max; + + r = read(fd, buf, rsize); if (r > 0) { size += r; if (do_write_check(handle, buf, r)) return 0; + if (max) { + max -= r; + if (!max) + break; + } } } while (r > 0); @@ -312,12 +321,62 @@ static tsize_t copy_file(struct tracecmd_output *handle, tracecmd_warning("Can't read '%s'", file); return 0; } - size = copy_file_fd(handle, fd); + size = copy_file_fd(handle, fd, 0); close(fd); return size; } +#define PAGES_IN_CHUNK 10 +__hidden unsigned long long out_copy_fd_compress(struct tracecmd_output *handle, + int fd, unsigned long long max, + unsigned long long *write_size) +{ + unsigned long long rsize = 0; + unsigned long long wsize = 0; + unsigned long long size; + int ret; + + if (handle->compress) { + rsize = max; + ret = tracecmd_compress_copy_from(handle->compress, fd, + PAGES_IN_CHUNK * handle->page_size, + &rsize, &wsize); + if (ret < 0) + return 0; + + size = rsize; + if (write_size) + *write_size = wsize; + } else { + size = copy_file_fd(handle, fd, max); + if (write_size) + *write_size = size; + } + + return size; +} + +static tsize_t copy_file_compress(struct tracecmd_output *handle, + const char *file, unsigned long long *write_size) +{ + int ret; + int fd; + + fd = open(file, O_RDONLY); + if (fd < 0) { + tracecmd_warning("Can't read '%s'", file); + return 0; + } + + ret = out_copy_fd_compress(handle, fd, 0, write_size); + if (!ret) + tracecmd_warning("Can't compress '%s'", file); + + close(fd); + return ret; +} + /* * Finds the path to the debugfs/tracing * Allocates the string and stores it. @@ -513,7 +572,7 @@ static int read_header_files(struct tracecmd_output *handle, bool compress) endian8 = convert_endian_8(handle, size); if (do_write_check(handle, &endian8, 8)) goto out_close; - check_size = copy_file_fd(handle, fd); + check_size = copy_file_fd(handle, fd, 0); close(fd); if (size != check_size) { tracecmd_warning("wrong size for '%s' size=%lld read=%lld", path, size, check_size); @@ -539,7 +598,7 @@ static int read_header_files(struct tracecmd_output *handle, bool compress) endian8 = convert_endian_8(handle, size); if (do_write_check(handle, &endian8, 8)) goto out_close; - check_size = copy_file_fd(handle, fd); + check_size = copy_file_fd(handle, fd, 0); close(fd); if (size != check_size) { tracecmd_warning("wrong size for '%s'", path); @@ -2181,7 +2240,7 @@ __hidden int out_write_cpu_data(struct tracecmd_output *handle, if (data[i].size) { if (lseek64(data[i].fd, data[i].offset, SEEK_SET) == (off64_t)-1) goto out_free; - read_size = copy_file_fd(handle, data[i].fd); + read_size = copy_file_fd(handle, data[i].fd, data[i].size); if (read_size != data_files[i].file_size) { errno = EINVAL; tracecmd_warning("did not match size of %lld to %lld",