| Message ID | 20220124105252.64897-2-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4ea007ab892bfc7bd3486372ffa3a6aee547109e |
| Headers | show |
| Series | [1/2] libtracefs: clean also docs by default | expand |
On Mon, 24 Jan 2022 11:52:52 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: Hi Krzysztof, When submitting a patch, can you have the first word start with a capital letter: "[PATCH 2/2] libtracefs: Fix utest linking path" > Build libraries are now in lib/. This fixes test error: > > /usr/bin/ld: cannot find ..libtracefs/lib/tracefs/libtracefs.a: No such file or directory > > Fixes: fe21539dc846 ("libtracefs: Build in the same directories as the source") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > utest/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utest/Makefile b/utest/Makefile > index d168b01a328c..74bf7e60b91d 100644 > --- a/utest/Makefile > +++ b/utest/Makefile > @@ -12,7 +12,7 @@ OBJS += tracefs-utest.o > > LIBS += -lcunit \ > -ldl \ > - $(obj)/lib/tracefs/libtracefs.a > + $(obj)/lib/libtracefs.a I was thinking how this failed for me. But I now see that my make clean never removed the old directory and library. Thanks for this! I'll apply it. -- Steve > > OBJS := $(OBJS:%.o=$(bdir)/%.o) > DEPS := $(OBJS:$(bdir)/%.o=$(bdir)/.%.d)
diff --git a/utest/Makefile b/utest/Makefile index d168b01a328c..74bf7e60b91d 100644 --- a/utest/Makefile +++ b/utest/Makefile @@ -12,7 +12,7 @@ OBJS += tracefs-utest.o LIBS += -lcunit \ -ldl \ - $(obj)/lib/tracefs/libtracefs.a + $(obj)/lib/libtracefs.a OBJS := $(OBJS:%.o=$(bdir)/%.o) DEPS := $(OBJS:$(bdir)/%.o=$(bdir)/.%.d)
Build libraries are now in lib/. This fixes test error: /usr/bin/ld: cannot find ..libtracefs/lib/tracefs/libtracefs.a: No such file or directory Fixes: fe21539dc846 ("libtracefs: Build in the same directories as the source") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- utest/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)