diff mbox series

[03/26] trace-cmd: Simplify add_guest()

Message ID	20220514024756.1319681-4-rostedt@goodmis.org (mailing list archive)
State	Accepted
Commit	ae9f80b268907e242b1f151a98c6445f67fba0bc
Headers	show Return-Path: <linux-trace-devel-owner@kernel.org> From: Steven Rostedt <rostedt@goodmis.org> To: linux-trace-devel@vger.kernel.org Cc: "Steven Rostedt (Google)" <rostedt@goodmis.org> Subject: [PATCH 03/26] trace-cmd: Simplify add_guest() Date: Fri, 13 May 2022 22:47:33 -0400 Message-Id: <20220514024756.1319681-4-rostedt@goodmis.org> In-Reply-To: <20220514024756.1319681-1-rostedt@goodmis.org> References: <20220514024756.1319681-1-rostedt@goodmis.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	trace-cmd: Add agent proxy (agent on the host) \| expand [00/26] trace-cmd: Add agent proxy (agent on the host) [01/26] trace-cmd record: Make start_threads() static [02/26] trace-cmd: Move add_guest_info() into trace-vm.c [03/26] trace-cmd: Simplify add_guest() [04/26] trace-cmd: Move find_pid_by_cid() into add_guest() [05/26] trace-cmd: Move find_tasks() into add_guest() [06/26] trace-cmd: Move trace_msg cache file to memfd [07/26] trace-cmd Makefile: Change test-build to link as well [08/26] trace-cmd agent: Test if memfd_create() is available [09/26] trace-cmd: Add kernel-doc to trace_record_agent() [10/26] trace-cmd: Move selecting tsync protocol out of tracecmd_tsync_with_host() [11/26] trace-cmd: Move accepting tsync connection out of tracecmd_tsync_with_host() [12/26] trace-cmd: Have get_vsocket_params() cid and rcid parameters be optional [13/26] trace-cmd agent: Add trace_tsync_as_guest() helper function [14/26] trace-cmd record: Pass cpu_count instead of an instance to stop_mapping_vcpus() [15/26] trace-cmd record: Add trace_tsync_as_host() helper [16/26] trace-cmd: Move tsync as guest and host helpers into trace-tsync.c [17/26] trace-cmd msg: Add PROXY communication [18/26] trace-cmd: Add agent proxy communications between record and agent [19/26] trace-cmd msg: Keep track of offset of flushed cache [20/26] trace-cmd library: Add tracecmd_prepare_options() [21/26] trace-cmd library: Add tracecmd_msg_flush_data() [22/26] trace-cmd agent proxy: Allow agent to send more meta data after trace [23/26] trace-cmd agent proxy: Add the remote guest cid to guest list [24/26] trace-cmd agent-proxy: Send options at the end of the trace [25/26] trace-cmd: Have the guest structure hold guest trace_id [26/26] trace-cmd: Have the host agent proxy control the time synchronization

Commit Message

Steven Rostedt May 14, 2022, 2:47 a.m. UTC

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

Simplify the function add_guest by using a local variable to point to the
array element instead of dereferencing the array every time.

Link: https://lore.kernel.org/linux-trace-devel/20220428150635.789051-3-rostedt@goodmis.org

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 tracecmd/trace-vm.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff mbox series

Patch

diff --git a/tracecmd/trace-vm.c b/tracecmd/trace-vm.c
index 47f8d96a4015..7a91038d75dc 100644
--- a/tracecmd/trace-vm.c
+++ b/tracecmd/trace-vm.c
@@ -56,18 +56,22 @@  bool trace_have_guests_pid(void)
 
 static struct trace_guest *add_guest(unsigned int cid, const char *name)
 {
+	struct trace_guest *guest;
+
 	guests = realloc(guests, (guests_len + 1) * sizeof(*guests));
 	if (!guests)
 		die("allocating new guest");
-	memset(&guests[guests_len], 0, sizeof(struct trace_guest));
-	guests[guests_len].name = strdup(name);
-	if (!guests[guests_len].name)
+
+	guest = &guests[guests_len++];
+
+	memset(guest, 0, sizeof(*guest));
+	guest->name = strdup(name);
+	if (!guest->name)
 		die("allocating guest name");
-	guests[guests_len].cid = cid;
-	guests[guests_len].pid = -1;
-	guests_len++;
+	guest->cid = cid;
+	guest->pid = -1;
 
-	return &guests[guests_len - 1];
+	return guest;
 }
 
 static struct tracefs_instance *start_trace_connect(void)