| Message ID | 20220901205638.3247090-1-zfigura@codeweavers.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9191b8e4278f0a1988b4ada6f9dd5c70e6061d89 |
| Headers | show |
| Series | tracecmd extract: Allow using --compression. | expand |
On Thu, 1 Sep 2022 15:56:38 -0500 Zebediah Figura <zfigura@codeweavers.com> wrote: > From: Zeb Figura <zfigura@codeweavers.com> > > This is already supported and works as expected; allow the option to be > specified. Hi Zeb, I'd love to accept this patch, but I need you to add your "Signed-off-by" tag. See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO You can either resend the patch, or reply with it here. Thanks! -- Steve > --- > tracecmd/trace-record.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c > index 3442e9b..70fb187 100644 > --- a/tracecmd/trace-record.c > +++ b/tracecmd/trace-record.c > @@ -6648,7 +6648,6 @@ static void parse_record_options(int argc, > case OPT_compression: > cmd_check_die(ctx, CMD_start, *(argv+1), "--compression"); > cmd_check_die(ctx, CMD_set, *(argv+1), "--compression"); > - cmd_check_die(ctx, CMD_extract, *(argv+1), "--compression"); > cmd_check_die(ctx, CMD_stream, *(argv+1), "--compression"); > cmd_check_die(ctx, CMD_profile, *(argv+1), "--compression"); > if (strcmp(optarg, "any") && strcmp(optarg, "none") &&
On 9/21/22 20:49, Steven Rostedt wrote: > On Thu, 1 Sep 2022 15:56:38 -0500 > Zebediah Figura <zfigura@codeweavers.com> wrote: > >> From: Zeb Figura <zfigura@codeweavers.com> >> >> This is already supported and works as expected; allow the option to be >> specified. > > Hi Zeb, > > I'd love to accept this patch, but I need you to add your "Signed-off-by" > tag. > > See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO > > You can either resend the patch, or reply with it here. Oops, I swear I even specifically remember seeing that in the contribution instructions, but forgot to actually add it :-( Sent as reply.
On Wed, 21 Sep 2022 21:20:57 -0500 Zebediah Figura <zfigura@codeweavers.com> wrote: > On 9/21/22 20:49, Steven Rostedt wrote: > > On Thu, 1 Sep 2022 15:56:38 -0500 > > Zebediah Figura <zfigura@codeweavers.com> wrote: > > > >> From: Zeb Figura <zfigura@codeweavers.com> > >> > >> This is already supported and works as expected; allow the option to be > >> specified. > > > > Hi Zeb, > > > > I'd love to accept this patch, but I need you to add your "Signed-off-by" > > tag. > > > > See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO > > > > You can either resend the patch, or reply with it here. > > Oops, I swear I even specifically remember seeing that in the > contribution instructions, but forgot to actually add it :-( > > Sent as reply. I still, need you to write the "Signed-off-by: Name <email>" part. As I'm not allowed to do it for you. -- Steve
Signed-off-by: Zeb Figura <zfigura@codeweavers.com>
On 9/22/22 07:39, Steven Rostedt wrote: > On Wed, 21 Sep 2022 21:20:57 -0500 > Zebediah Figura <zfigura@codeweavers.com> wrote: > >> On 9/21/22 20:49, Steven Rostedt wrote: >>> On Thu, 1 Sep 2022 15:56:38 -0500 >>> Zebediah Figura <zfigura@codeweavers.com> wrote: >>> >>>> From: Zeb Figura <zfigura@codeweavers.com> >>>> >>>> This is already supported and works as expected; allow the option to be >>>> specified. >>> >>> Hi Zeb, >>> >>> I'd love to accept this patch, but I need you to add your "Signed-off-by" >>> tag. >>> >>> See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO >>> >>> You can either resend the patch, or reply with it here. >> >> Oops, I swear I even specifically remember seeing that in the >> contribution instructions, but forgot to actually add it :-( >> >> Sent as reply. > > I still, need you to write the "Signed-off-by: Name <email>" part. As I'm > not allowed to do it for you. Gah, I managed to send it as a reply to myself. Sorry about this, I swear I usually am more capable of sending sign-offs...
On Thu, 22 Sep 2022 10:25:23 -0500
Zebediah Figura <zfigura@codeweavers.com> wrote:
> Signed-off-by: Zeb Figura <zfigura@codeweavers.com>
Thanks!
-- Steve
On Thu, 22 Sep 2022 10:26:40 -0500 Zebediah Figura <zfigura@codeweavers.com> wrote: > > I still, need you to write the "Signed-off-by: Name <email>" part. As I'm > > not allowed to do it for you. > > Gah, I managed to send it as a reply to myself. Sorry about this, I > swear I usually am more capable of sending sign-offs... No problem. I applied it. Thanks Zeb! -- Steve
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 3442e9b..70fb187 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -6648,7 +6648,6 @@ static void parse_record_options(int argc, case OPT_compression: cmd_check_die(ctx, CMD_start, *(argv+1), "--compression"); cmd_check_die(ctx, CMD_set, *(argv+1), "--compression"); - cmd_check_die(ctx, CMD_extract, *(argv+1), "--compression"); cmd_check_die(ctx, CMD_stream, *(argv+1), "--compression"); cmd_check_die(ctx, CMD_profile, *(argv+1), "--compression"); if (strcmp(optarg, "any") && strcmp(optarg, "none") &&
From: Zeb Figura <zfigura@codeweavers.com> This is already supported and works as expected; allow the option to be specified. --- tracecmd/trace-record.c | 1 - 1 file changed, 1 deletion(-)