| Message ID | 20221123183248.554-1-beaub@linux.microsoft.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | tracing/user_events: Fix call print_fmt leak | expand |
On Wed, 23 Nov 2022 10:32:48 -0800 Beau Belgrave <beaub@linux.microsoft.com> wrote: > If user_event_trace_register() fails within user_event_parse() the > call's print_fmt member is not freed. Add kfree call to fix this. > > Fixes: aa3b2b4c6692 ("user_events: Add print_fmt generation support for basic types") > Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com> This looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thank you! > --- > kernel/trace/trace_events_user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c > index ae78c2d53c8a..b46844736015 100644 > --- a/kernel/trace/trace_events_user.c > +++ b/kernel/trace/trace_events_user.c > @@ -1357,6 +1357,7 @@ static int user_event_parse(struct user_event_group *group, char *name, > put_user: > user_event_destroy_fields(user); > user_event_destroy_validators(user); > + kfree(user->call.print_fmt); > kfree(user); > return ret; > } > -- > 2.25.1 >
diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index ae78c2d53c8a..b46844736015 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1357,6 +1357,7 @@ static int user_event_parse(struct user_event_group *group, char *name, put_user: user_event_destroy_fields(user); user_event_destroy_validators(user); + kfree(user->call.print_fmt); kfree(user); return ret; }
If user_event_trace_register() fails within user_event_parse() the call's print_fmt member is not freed. Add kfree call to fix this. Fixes: aa3b2b4c6692 ("user_events: Add print_fmt generation support for basic types") Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com> --- kernel/trace/trace_events_user.c | 1 + 1 file changed, 1 insertion(+)