diff mbox series

[v2] libtraceevent: Make sure 32 bit works on 64 bit file systems

Message ID 20221221134051.53aad658@gandalf.local.home (mailing list archive)
State Superseded
Headers show
Series [v2] libtraceevent: Make sure 32 bit works on 64 bit file systems | expand

Commit Message

Steven Rostedt Dec. 21, 2022, 6:40 p.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

As stat() can overflow if a 32 bit user space reads a file on a file
system that has inodes greater than MAX_INT. Compile with
_FILE_OFFSET_BITS=64 that mitigates this problem on 32 bit user space.

Reported-by: Mike Frysinger <vapier@google.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ross Zwisler Dec. 22, 2022, 5:35 p.m. UTC | #1 
On Wed, Dec 21, 2022 at 01:40:51PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> 
> As stat() can overflow if a 32 bit user space reads a file on a file
> system that has inodes greater than MAX_INT. Compile with
> _FILE_OFFSET_BITS=64 that mitigates this problem on 32 bit user space.
> 
> Reported-by: Mike Frysinger <vapier@google.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Tested-by: Ross Zwisler <zwisler@google.com>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 965ff47eae7d..a8a56b6773be 100644
--- a/Makefile
+++ b/Makefile
@@ -130,6 +130,9 @@  else
   CFLAGS := -g -Wall
 endif
 
+# Make sure 32 bit stat() works on large file systems
+CFLAGS += -D_FILE_OFFSET_BITS=64
+
 LIBS ?= -ldl
 export LIBS