| Message ID | 20230220175241.15424-1-alice@ayaya.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 73f6a8ac2920a35a9acd4ca7b95062d1aef361b8 |
| Headers | show |
| Series | libtraceevent: fix some missing commas in big endian blocks | expand |
On Mon, 20 Feb 2023 18:52:41 +0100 psykose <alice@ayaya.dev> wrote: > the lack of a trailing comma makes the array definition invalid, since elements > must be comma delimited in the initialiser. so, add one in the big endian case > too. Thanks. I was also wondering if anyone was doing anything with big endian these days ;-) -- Steve > > Signed-off-by: psykose <alice@ayaya.dev> > ---
diff --git a/utest/traceevent-utest.c b/utest/traceevent-utest.c index ebd5eb9..041843e 100644 --- a/utest/traceevent-utest.c +++ b/utest/traceevent-utest.c @@ -45,7 +45,7 @@ static char dyn_str_data[] = { #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ /* common type */ 1, 0x00, #else - /* common type */ 0x00, 1 + /* common type */ 0x00, 1, #endif /* common flags */ 0x00, /* common_preempt_count */ 0x00, @@ -82,7 +82,7 @@ static char dyn_str_old_data[] = { #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ /* common type */ 2, 0x00, #else - /* common type */ 0x00, 2 + /* common type */ 0x00, 2, #endif /* common flags */ 0x00, /* common_preempt_count */ 0x00, @@ -166,7 +166,7 @@ static char sizeof_data[] = { #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ /* common type */ 23, 0x00, #else - /* common type */ 0x00, 23 + /* common type */ 0x00, 23, #endif /* common flags */ 0x00, /* common_preempt_count */ 0x00,
the lack of a trailing comma makes the array definition invalid, since elements must be comma delimited in the initialiser. so, add one in the big endian case too. Signed-off-by: psykose <alice@ayaya.dev> --- utest/traceevent-utest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)