diff mbox series

libtracefs/utest: Fix crashing of synth test when synths exist

Message ID 20230530025627.19df3714@rorschach.local.home (mailing list archive)
State Accepted
Commit 857dd3e2a45a865037d7351b90c902cf152d2888
Headers show
Series libtracefs/utest: Fix crashing of synth test when synths exist | expand

Commit Message

Steven Rostedt May 30, 2023, 6:56 a.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

If a synthetic event already exists when running the synthetic event test,
it does a SEGFAULT. This is because the sevents passed into
test_synth_compare() is dependent on the devents size. If there's
already a synthetic event, devents will be bigger than sevents, and the
sevents will read out of bounds. Check for devents to be the same size as
sevents before calling test_synth_compare()

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 utest/tracefs-utest.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff mbox series

Patch

diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c
index 0f4075679ec4..3d88d927e320 100644
--- a/utest/tracefs-utest.c
+++ b/utest/tracefs-utest.c
@@ -1047,6 +1047,12 @@  static void test_instance_synthetic(struct tracefs_instance *instance)
 
 	devents = get_dynevents_check(TRACEFS_DYNEVENT_SYNTH, sevents_count);
 	CU_TEST(devents != NULL);
+	if (!devents)
+		goto out;
+	CU_TEST(devents[sevents_count] == NULL);
+	if (devents[sevents_count])
+		goto out;
+
 	test_synth_compare(sevents, devents);
 	tracefs_dynevent_list_free(devents);
 
@@ -1057,6 +1063,7 @@  static void test_instance_synthetic(struct tracefs_instance *instance)
 
 	get_dynevents_check(TRACEFS_DYNEVENT_SYNTH, 0);
 
+ out:
 	for (i = 0; i < sevents_count; i++)
 		tracefs_synth_free(synth[i]);