diff mbox series

trace-cmd extract: Do not extract top level unless told to

Message ID 20230601075053.3fa7dd9b@rorschach.local.home (mailing list archive)
State Accepted
Commit 9c9d5ed97fcd7e5d1308c4f589d01949c8a1b007
Headers show
Series trace-cmd extract: Do not extract top level unless told to | expand

Commit Message

Steven Rostedt June 1, 2023, 11:50 a.m. UTC 
From: Steven Rostedt (Google) <rostedt@goodmis.org>

The trace-cmd extract man pages explicitly states that if the '-B'
option is used, it will only extract the given instance and not touch
any other buffer instance including the top level, unless '-t' is given
(for the top level) or '-a' (for all instances). But currently it is
hard coded to extract the top level. Make extract only touch what it is
told according to the documentation.

Reported-by: Douglas RAILLARD <douglas.raillard@arm.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=217340
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
diff mbox series

Patch

diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index f852aa71..56b7991a 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -7278,7 +7278,7 @@  void trace_extract(int argc, char **argv)
 
 	type = get_trace_cmd_type(ctx.curr_cmd);
 
-	update_first_instance(ctx.instance, 1);
+	update_first_instance(ctx.instance, ctx.topt);
 	check_function_plugin();
 
 	if (!ctx.output)