diff mbox series

libtracefs: fix cscope makefile rule

Message ID 20230801172709.681696-1-zwisler@kernel.org (mailing list archive)
State Superseded
Headers show
Series libtracefs: fix cscope makefile rule | expand

Commit Message

Ross Zwisler Aug. 1, 2023, 5:27 p.m. UTC 
From: Ross Zwisler <zwisler@google.com>

The current 'make cscope' rule does not actually pass the filenames
gathered by 'find' to cscope.  cscope expects them either to be passed
on the command line, as this patch does with xargs, or via a
'cscope.files' intermediate file.   It doesn't read them from stdin.

As long as the file count is low, as it is in this library, the command
line version works fine.  Larger projects like the kernel need to use
the intermediate file.

Signed-off-by: Ross Zwisler <zwisler@google.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 9f377e9..80076aa 100644
--- a/Makefile
+++ b/Makefile
@@ -256,7 +256,7 @@  $(EMACS_TAGS): force
 
 $(CSCOPE_TAGS): force
 	$(RM) $(obj)/cscope*
-	$(call find_tag_files) | cscope -b -q
+	$(call find_tag_files) | xargs cscope -b -q
 
 tags: $(VIM_TAGS)
 TAGS: $(EMACS_TAGS)