diff mbox series

traceeval: Fix traceeval_insert() macro for NULL vals

Message ID 20230928051511.074ab689@rorschach.local.home (mailing list archive)
State Superseded
Headers show
Series traceeval: Fix traceeval_insert() macro for NULL vals | expand

Commit Message

Steven Rostedt Sept. 28, 2023, 9:15 a.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

If the vals is NULL (which is valid), the traceeval_insert() macro calls
traceeval_insert_size() with sizeof(vals)/sizeof(vals[0]) to get the
number of vals in the array. But this does not make sense with a NULL
value. Check for NULL and if vals is NULL then pass in zero.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 include/traceeval-hist.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/include/traceeval-hist.h b/include/traceeval-hist.h
index eefa48d5d772..f6caed6a2a98 100644
--- a/include/traceeval-hist.h
+++ b/include/traceeval-hist.h
@@ -187,7 +187,7 @@  int traceeval_insert_size(struct traceeval *teval,
 
 #define traceeval_insert(teval, keys, vals)				\
 	traceeval_insert_size(teval, keys, TRACEEVAL_ARRAY_SIZE(keys), \
-			      vals, TRACEEVAL_ARRAY_SIZE(vals))
+			      vals, vals ? TRACEEVAL_ARRAY_SIZE(vals) : 0)
 
 int traceeval_remove_size(struct traceeval *teval,
 			  const struct traceeval_data *keys, size_t nr_keys);