diff mbox series

[2/3] trace-cmd library: Add back setting errno to zero in tracecmd_stack_tracer_status()

Message ID 20231229031138.68313-3-rostedt@goodmis.org (mailing list archive)
State Accepted
Commit 6e801ee7e0a399df240723db025a038af69483bf
Headers show
Series trace-cmd library: Fixes and add a reset | expand

Commit Message

Steven Rostedt Dec. 29, 2023, 3:10 a.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

A clean up was made to remove all the settings of errno to zero in the
library, but it was a bit too aggressive in doing so. It removed the errno
setting to zero in tracecmd_stack_tracer_status() just before it called
strtol() which it uses to test for the success of that function. By not
clearing errno, it was causing trace-cmd stat to report:

 "Error reading stack tracer status"

Fixes: dcd5ee3142 ("libtracecmd: Do not set errno to zero")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 lib/trace-cmd/trace-util.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c
index fc61f9d1111b..b5002f1daa07 100644
--- a/lib/trace-cmd/trace-util.c
+++ b/lib/trace-cmd/trace-util.c
@@ -557,6 +557,7 @@  int tracecmd_stack_tracer_status(int *status)
 
 	buf[n] = 0;
 
+	errno = 0;
 	num = strtol(buf, NULL, 10);
 
 	/* Check for various possible errors */