diff mbox series

[2/3] utest/tracefs-utest: add missing define

Message ID 20240215-utest-fixes-v1-2-24678d859de2@gmail.com (mailing list archive)
State Superseded
Headers show
Series utest: fix FTBFS with clang >=15 | expand

Commit Message

Miko Larsson via B4 Relay Feb. 15, 2024, 9:02 a.m. UTC
From: Miko Larsson <mikoxyzzz@gmail.com>

Fixes FTBFS with clang >=15

Fixes: 0f45e68cb04a ("libtracefs: Add unit tests for tracefs_cpu functions")
Signed-off-by: Miko Larsson <mikoxyzzz@gmail.com>
---
 utest/tracefs-utest.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Steven Rostedt Feb. 21, 2024, 11:49 p.m. UTC | #1
On Thu, 15 Feb 2024 10:02:42 +0100
Miko Larsson via B4 Relay <devnull+mikoxyzzz.gmail.com@kernel.org> wrote:

> From: Miko Larsson <mikoxyzzz@gmail.com>
> 
> Fixes FTBFS with clang >=15

FTBFS is a rather useless explanation (and I had to even look it up to find
out what it is ;-)

The change log should show the error and explain why the change fixes the
problem.

Thanks,

-- Steve


> 
> Fixes: 0f45e68cb04a ("libtracefs: Add unit tests for tracefs_cpu functions")
> Signed-off-by: Miko Larsson <mikoxyzzz@gmail.com>
> ---
>  utest/tracefs-utest.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c
> index a798ace..e30e8e7 100644
> --- a/utest/tracefs-utest.c
> +++ b/utest/tracefs-utest.c
> @@ -3,6 +3,8 @@
>   * Copyright (C) 2020, VMware, Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
>   *
>   */
> +#define _LARGEFILE64_SOURCE
> +
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <sys/stat.h>
>
Miko Larsson Feb. 22, 2024, 8:59 a.m. UTC | #2
On Thu Feb 22, 2024 at 12:49 AM CET, Steven Rostedt wrote:
> FTBFS is a rather useless explanation (and I had to even look it up to find
> out what it is ;-)
>
> The change log should show the error and explain why the change fixes the
> problem.
Heh, yeah, you're right. Thanks.
diff mbox series

Patch

diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c
index a798ace..e30e8e7 100644
--- a/utest/tracefs-utest.c
+++ b/utest/tracefs-utest.c
@@ -3,6 +3,8 @@ 
  * Copyright (C) 2020, VMware, Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
  *
  */
+#define _LARGEFILE64_SOURCE
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/stat.h>