diff mbox series

trace-cmd record: Do not remove instances with -v

Message ID 20240718214806.27dfb413@gandalf.local.home (mailing list archive)
State Accepted
Commit b60774a6473f10409c46fdef7f0d981b08670012
Headers show
Series trace-cmd record: Do not remove instances with -v | expand

Commit Message

Steven Rostedt July 19, 2024, 1:48 a.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The -v option was extended to delete instances. But this does not make sense
with the 'record' command. It only makes sense with the 'set' command.
Make sure that the 'set' command is used when deleting an instance,
otherwise it can cause adverse effects on the record side.

Link: https://lore.kernel.org/all/20240605134054.2626953-34-jmarchan@redhat.com/

Fixes: 2a3c58e75 ("trace-cmd: Extend option "-v" to delete an ftrace instance")
Reported-by: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 tracecmd/trace-record.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 4e9ac598..1527be11 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -6748,7 +6748,8 @@  static void parse_record_options(int argc,
 			ctx->instance = allocate_instance(optarg);
 			if (!ctx->instance)
 				die("Failed to create instance");
-			ctx->instance->delete = negative;
+			if (IS_CMDSET(ctx))
+				ctx->instance->delete = negative;
 			negative = 0;
 			if (ctx->instance->delete) {
 				ctx->instance->next = del_list;