diff mbox series

trace-cmd documentation: Remove check-manpages.sh for trace-cmd in meson build

Message ID 20240725112620.17c6d1b2@gandalf.local.home (mailing list archive)
State Accepted
Commit 0bacc5ed74c26617ed9ce92fd138d06fff7d86af
Headers show
Series trace-cmd documentation: Remove check-manpages.sh for trace-cmd in meson build | expand

Commit Message

Steven Rostedt July 25, 2024, 3:26 p.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The creation of man pages for trace-cmd ran the check-manpages.sh script,
which is only used for the libtracecmd library, not the tools. This caused
the build to spit out warning of grep not finding libtracecmd.txt.

Fixes: 736df0648d16b ("trace-cmd: Add initial support for meson")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 Documentation/trace-cmd/meson.build | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Daniel Wagner July 30, 2024, 4:40 p.m. UTC | #1 
On Thu, Jul 25, 2024 at 11:26:20AM GMT, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> 
> The creation of man pages for trace-cmd ran the check-manpages.sh script,
> which is only used for the libtracecmd library, not the tools. This caused
> the build to spit out warning of grep not finding libtracecmd.txt.

Ah, okay, didn't noticed that back then.

> Fixes: 736df0648d16b ("trace-cmd: Add initial support for meson")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Anyway, looks good.

Reviewed-by: Daniel Wagner <dwagner@suse.de>
diff mbox series

Patch

diff --git a/Documentation/trace-cmd/meson.build b/Documentation/trace-cmd/meson.build
index d0cc3076d985..875d72832a0b 100644
--- a/Documentation/trace-cmd/meson.build
+++ b/Documentation/trace-cmd/meson.build
@@ -104,13 +104,6 @@  if get_option('docbook-suppress-sp')
     xmlto_extra += ['-m ',  confdir + 'manpage-suppress-sp.xsl']
 endif
 
-check_doc = custom_target(
-    'check-doc',
-    output: 'dummy',
-    command : [
-        top_source_dir + 'check-manpages.sh',
-        meson.current_source_dir()])
-
 gen = generator(
     asciidoc,
     output: '@BASENAME@.xml',
@@ -131,7 +124,6 @@  foreach txt, section : sources
         txt.underscorify() + '_man',
         input: xml,
         output: '@BASENAME@.' + section,
-        depends: check_doc,
         command: [
             xmlto,
             '-m', manpage_xsl,
@@ -145,7 +137,6 @@  foreach txt, section : sources
         txt.underscorify() + '_html',
         input: txt,
         output: '@BASENAME@.html',
-        depends: check_doc,
         command: [
             asciidoc,
             '-b', asciidoc_html,