mbox series

[v1,0/1] Add trace events for remoteproc

Message ID 20230224165142.17745-1-quic_gokukris@quicinc.com (mailing list archive)
Headers show
Series Add trace events for remoteproc | expand

Message

Gokul krishna Krishnakumar Feb. 24, 2023, 4:51 p.m. UTC 
This patch attempts to add traces for important remoteproc events,
this will help in debugging errors with the subsystem restart and
also helps in getting an estimate on how long each event takes to run.

Gokul krishna Krishnakumar (1):
  remoteproc: qcom: Add remoteproc tracing

 drivers/remoteproc/Makefile           |  3 ++-
 drivers/remoteproc/qcom_common.c      | 25 +++++++++++++++++++
 drivers/remoteproc/qcom_q6v5.c        |  3 +++
 drivers/remoteproc/qcom_q6v5_pas.c    | 17 +++++++++++++
 drivers/remoteproc/qcom_sysmon.c      | 13 ++++++++++
 drivers/remoteproc/qcom_tracepoints.c | 10 ++++++++
 include/trace/events/rproc_qcom.h     | 36 +++++++++++++++++++++++++++
 7 files changed, 106 insertions(+), 1 deletion(-)
 create mode 100644 drivers/remoteproc/qcom_tracepoints.c
 create mode 100644 include/trace/events/rproc_qcom.h


base-commit: 7c855ef7137a67bcff0e039691b969428dd8ef6a

Comments

Bjorn Andersson Feb. 27, 2023, 7:36 p.m. UTC | #1 
On Fri, Feb 24, 2023 at 08:51:41AM -0800, Gokul krishna Krishnakumar wrote:
> This patch attempts to add traces for important remoteproc events,
> this will help in debugging errors with the subsystem restart and
> also helps in getting an estimate on how long each event takes to run.
> 

Please skip sending cover-letters for single patches. Also, this is the
kind of motivation that should be included in the commit message.

Thanks,
Bjorn

> Gokul krishna Krishnakumar (1):
>   remoteproc: qcom: Add remoteproc tracing
> 
>  drivers/remoteproc/Makefile           |  3 ++-
>  drivers/remoteproc/qcom_common.c      | 25 +++++++++++++++++++
>  drivers/remoteproc/qcom_q6v5.c        |  3 +++
>  drivers/remoteproc/qcom_q6v5_pas.c    | 17 +++++++++++++
>  drivers/remoteproc/qcom_sysmon.c      | 13 ++++++++++
>  drivers/remoteproc/qcom_tracepoints.c | 10 ++++++++
>  include/trace/events/rproc_qcom.h     | 36 +++++++++++++++++++++++++++
>  7 files changed, 106 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/remoteproc/qcom_tracepoints.c
>  create mode 100644 include/trace/events/rproc_qcom.h
> 
> 
> base-commit: 7c855ef7137a67bcff0e039691b969428dd8ef6a
> -- 
> 2.39.2
>
Gokul krishna Krishnakumar Feb. 27, 2023, 7:54 p.m. UTC | #2 
On 2/27/2023 11:36 AM, Bjorn Andersson wrote:
> On Fri, Feb 24, 2023 at 08:51:41AM -0800, Gokul krishna Krishnakumar wrote:
>> This patch attempts to add traces for important remoteproc events,
>> this will help in debugging errors with the subsystem restart and
>> also helps in getting an estimate on how long each event takes to run.
>>
> 
> Please skip sending cover-letters for single patches. Also, this is the
> kind of motivation that should be included in the commit message.
> 
> Thanks,
> Bjorn
> 
Thanks Bjorn, Moving this to the commit text.
>> Gokul krishna Krishnakumar (1):
>>    remoteproc: qcom: Add remoteproc tracing
>>
>>   drivers/remoteproc/Makefile           |  3 ++-
>>   drivers/remoteproc/qcom_common.c      | 25 +++++++++++++++++++
>>   drivers/remoteproc/qcom_q6v5.c        |  3 +++
>>   drivers/remoteproc/qcom_q6v5_pas.c    | 17 +++++++++++++
>>   drivers/remoteproc/qcom_sysmon.c      | 13 ++++++++++
>>   drivers/remoteproc/qcom_tracepoints.c | 10 ++++++++
>>   include/trace/events/rproc_qcom.h     | 36 +++++++++++++++++++++++++++
>>   7 files changed, 106 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/remoteproc/qcom_tracepoints.c
>>   create mode 100644 include/trace/events/rproc_qcom.h
>>
>>
>> base-commit: 7c855ef7137a67bcff0e039691b969428dd8ef6a
>> -- 
>> 2.39.2
>>
Thanks,
Gokul